Re: [PATCH proxmox-backup v3 2/3] fix #6990: server: drop verify state on push job

[Christian Ebner <c.ebner@proxmox.com>]

On 9/22/26 3:11 PM, Jakob Klocker wrote:
> When pushing a snapshot the target manifest is recreated from the source
> manifest, copying its verify_state. As with pull, this makes the pushed
> snapshot appear verified on the remote without its stored copy having
> been checked there.
> Strip verify_state after copying the unprotected section so the pushed
> snapshot is verified independently on the target.
> 
> Link: https://bugzilla.proxmox.com/show_bug.cgi?id=6990
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>

As on the last version of the patches, consider:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>

> ---
>   src/server/push.rs | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/src/server/push.rs b/src/server/push.rs
> index 487fd91e3..0b754ac2b 100644
> --- a/src/server/push.rs
> +++ b/src/server/push.rs
> @@ -1453,6 +1453,13 @@ pub(crate) async fn push_snapshot(
>       } else {
>           target_manifest.signature = source_manifest.signature.clone();
>       };
> +
> +    if let Some(unprotected) = target_manifest.unprotected.as_object_mut() {
> +        unprotected.remove("verify_state");
> +    } else {
> +        bail!("Encountered unexpected manifest without 'unprotected' section.");
> +    }
> +
>       // FIXME: replace me with to_data_blob once there is an upload_blob
>       let manifest_string =
>           target_manifest.to_string(encrypt_using_key.map(|(_, config)| config).as_deref())?;