Re: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output

[Christian Ebner <c.ebner@proxmox.com>]

On 8/27/26 5:48 PM, Jonas Theisen wrote:
> Currently running tasks are returned by the PBS API in the query
> for errored tasks.
> This patch adds an additional condition to filter out running tasks
> when queried for errored tasks.
> 
> Reported in https://forum.proxmox.com/threads/163872/,
> https://forum.proxmox.com/threads/185999/ and
> https://bugzilla.proxmox.com/show_bug.cgi?id=6251
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   src/api2/node/tasks.rs | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/api2/node/tasks.rs b/src/api2/node/tasks.rs
> index 96f5e080f..4786820a3 100644
> --- a/src/api2/node/tasks.rs
> +++ b/src/api2/node/tasks.rs
> @@ -610,6 +610,7 @@ pub fn list_tasks(
>               (Some(state), Some(filters)) if !filters.contains(&tasktype(state)) => {
>                   continue;
>               }
> +            (None, _) if errors => continue,
>               (None, Some(_)) => continue,
>               _ => {}
>           }

Thanks for the patch! Did you also check the task filter implementations 
in PVE/PDM?

At least for PDM there is some analogous logic [0] which at first glance 
requires adaption as well. Note that there it is shared for PVE and PBS.

[0] 
https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=server/src/remote_tasks/mod.rs;h=5fba867dfc675970ebc5037165f49efee439f545;hb=HEAD#l143