From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 821DF1FF0C5 for ; Fri, 28 Aug 2026 09:10:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 22F18213F6; Fri, 28 Aug 2026 09:10:09 +0200 (CEST) Message-ID: Date: Fri, 28 Aug 2026 09:09:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output To: Jonas Theisen , pbs-devel@lists.proxmox.com References: <20260827154740.427154-1-j.theisen@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260827154740.427154-1-j.theisen@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787900988672 X-SPAM-LEVEL: Spam detection results: 1 AWL -1.796 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_DBL_SPAM 5 Contains a spam URL listed in the Spamhaus DBL blocklist [tasks.rs] Message-ID-Hash: Y2QBG3R73RAJF4NM3OWXQ3R4M2IW5DL3 X-Message-ID-Hash: Y2QBG3R73RAJF4NM3OWXQ3R4M2IW5DL3 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/27/26 5:48 PM, Jonas Theisen wrote: > Currently running tasks are returned by the PBS API in the query > for errored tasks. > This patch adds an additional condition to filter out running tasks > when queried for errored tasks. > > Reported in https://forum.proxmox.com/threads/163872/, > https://forum.proxmox.com/threads/185999/ and > https://bugzilla.proxmox.com/show_bug.cgi?id=6251 > > Signed-off-by: Jonas Theisen > --- > src/api2/node/tasks.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/api2/node/tasks.rs b/src/api2/node/tasks.rs > index 96f5e080f..4786820a3 100644 > --- a/src/api2/node/tasks.rs > +++ b/src/api2/node/tasks.rs > @@ -610,6 +610,7 @@ pub fn list_tasks( > (Some(state), Some(filters)) if !filters.contains(&tasktype(state)) => { > continue; > } > + (None, _) if errors => continue, > (None, Some(_)) => continue, > _ => {} > } Thanks for the patch! Did you also check the task filter implementations in PVE/PDM? At least for PDM there is some analogous logic [0] which at first glance requires adaption as well. Note that there it is shared for PVE and PBS. [0] https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=server/src/remote_tasks/mod.rs;h=5fba867dfc675970ebc5037165f49efee439f545;hb=HEAD#l143