From: "Jakob Klocker" <j.klocker@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pbs-devel@lists.proxmox.com>
Subject: superseded: [PATCH proxmox-backup 0/2] fix #6990: server: drop verify state on push & pull job
Date: Mon, 24 Aug 2026 14:31:45 +0200 [thread overview]
Message-ID: <DKX6CIQH41PI.3O6WCN5302X97@proxmox.com> (raw)
In-Reply-To: <20260709122136.352839-1-j.klocker@proxmox.com>
Superseded-by: https://lore.proxmox.com/all/20260821111826.299588-1-j.klocker@proxmox.com/T/#u
On Thu Jul 9, 2026 at 2:21 PM CEST, Jakob Klocker wrote:
> When syncing a snapshot to another datastore, the source's verify_state is
> currently carried over to the target. This reports the target snapshot as
> verified even though its stored copy was never checked there. Since verify
> jobs skip snapshots that already carry a verify_state, the target's copy
> can't be verified again.
>
> Chunks are checksummed in memory while being transferred, but a verify
> serves a different purpose: confirming the write to the (external) target
> actually succeeded.
>
> This series drops verify_state on sync so the target is verified
> independently. The state is dropped by default.
>
> Tested (verify_state correctly stripped on target):
> * Pull, verified source, new content, clean sync
> * Pull, verified source, existing content, clean sync
> * Pull, corrupted target, resync-corrupt
> * Push, verified source (has no corrupt path)
> * Pull, independently-verified target, clean re-sync - state preserved
>
> Link: https://bugzilla.proxmox.com/show_bug.cgi?id=6990
>
>
> proxmox-backup:
>
> Jakob Klocker (2):
> fix #6990: server: drop verify state on non-decrypt pull job
> fix #6990: server: drop verify state on push job
>
> src/server/pull.rs | 42 ++++++++++++++++++++++++++++--------------
> src/server/push.rs | 6 ++++++
> 2 files changed, 34 insertions(+), 14 deletions(-)
>
>
> Summary over all repositories:
> 2 files changed, 34 insertions(+), 14 deletions(-)
prev parent reply other threads:[~2026-08-24 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:21 [PATCH proxmox-backup 0/2] fix #6990: server: drop verify state on push & pull job Jakob Klocker
2026-07-09 12:21 ` [PATCH proxmox-backup 1/2] fix #6990: server: drop verify state on non-decrypt " Jakob Klocker
2026-07-23 11:08 ` Christian Ebner
2026-07-24 8:11 ` Jakob Klocker
2026-07-09 12:21 ` [PATCH proxmox-backup 2/2] fix #6990: server: drop verify state on push job Jakob Klocker
2026-08-24 12:31 ` Jakob Klocker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKX6CIQH41PI.3O6WCN5302X97@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox