From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AD29F1FF0B2 for ; Mon, 24 Aug 2026 14:31:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7CA20215BD; Mon, 24 Aug 2026 14:31:49 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 24 Aug 2026 14:31:45 +0200 Message-Id: Subject: superseded: [PATCH proxmox-backup 0/2] fix #6990: server: drop verify state on push & pull job From: "Jakob Klocker" To: "Jakob Klocker" , X-Mailer: aerc 0.20.0 References: <20260709122136.352839-1-j.klocker@proxmox.com> In-Reply-To: <20260709122136.352839-1-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787574675404 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.775 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NIASUPFI6GEBGGLRHMVBCZOPC2M2TMY6 X-Message-ID-Hash: NIASUPFI6GEBGGLRHMVBCZOPC2M2TMY6 X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/all/20260821111826.299588-1-j.klock= er@proxmox.com/T/#u On Thu Jul 9, 2026 at 2:21 PM CEST, Jakob Klocker wrote: > When syncing a snapshot to another datastore, the source's verify_state i= s > currently carried over to the target. This reports the target snapshot as > verified even though its stored copy was never checked there. Since verif= y > jobs skip snapshots that already carry a verify_state, the target's copy > can't be verified again. > > Chunks are checksummed in memory while being transferred, but a verify > serves a different purpose: confirming the write to the (external) target > actually succeeded. > > This series drops verify_state on sync so the target is verified > independently. The state is dropped by default. > > Tested (verify_state correctly stripped on target): > * Pull, verified source, new content, clean sync > * Pull, verified source, existing content, clean sync > * Pull, corrupted target, resync-corrupt > * Push, verified source (has no corrupt path) > * Pull, independently-verified target, clean re-sync - state preserved > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=3D6990 > > > proxmox-backup: > > Jakob Klocker (2): > fix #6990: server: drop verify state on non-decrypt pull job > fix #6990: server: drop verify state on push job > > src/server/pull.rs | 42 ++++++++++++++++++++++++++++-------------- > src/server/push.rs | 6 ++++++ > 2 files changed, 34 insertions(+), 14 deletions(-) > > > Summary over all repositories: > 2 files changed, 34 insertions(+), 14 deletions(-)