Re: [RFC PATCH proxmox-backup 2/6] fix #7024: pxar: show archiver summary for legacy and data mode

[Christian Ebner <c.ebner@proxmox.com>]

On 6/10/26 8:02 PM, Shan Shaji wrote:
> earlier, the archiver summary was only being shown when the change
> detection mode is metadata. To improve this, log the total number of
> files and the amount of data re-encoded for legacy and data modes
> as well.
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   pbs-client/src/pxar/create.rs | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index c7f26879e..9100ac1a3 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -348,6 +348,15 @@ where
>               ),
>               archiver.progress_stats.partial_chunks_count,
>           );
> +    } else {
> +        info!("Processing summary:");
> +        info!(
> +            "- {} total files ({} hardlinks) with {} data",
> +            archiver.progress_stats.files_reencoded_count
> +                + archiver.progress_stats.files_hardlink_count,

nit: the total here is basically the same as for the metadata mode above 
(since reuse being 0)

this could therefore be defined as common helper (see suggested diff below).

But maybe even better, since you move these to atomic counters in patch 
3 anyways, maybe reorder them and do the conversion first, then you 
already have the helper you need at hand anyways.

> +            archiver.progress_stats.files_hardlink_count,
> +            HumanByte::from(archiver.progress_stats.total_reencoded_size),
> +        );
>       }
>       Ok(())
>   }


diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
index 56296171e..e541b829b 100644
--- a/pbs-client/src/pxar/create.rs
+++ b/pbs-client/src/pxar/create.rs
@@ -161,6 +161,14 @@ struct PxarArchiverProgressStats {
      total_reencoded_size: u64,
  }

+impl PxarArchiverProgressStats {
+    fn total_files_processed(&self) -> u64 {
+        self.files_reused_count
+            + self.files_reencoded_count
+            + self.files_hardlink_count
+    }
+}
+
  #[derive(Serialize, Deserialize)]
  #[serde(rename_all = "kebab-case")]
  pub(crate) struct PbsClientPrelude {
@@ -325,9 +333,7 @@ where
          info!("Change detection summary:");
          info!(
              " - {} total files ({} hardlinks)",
-            archiver.progress_stats.files_reused_count
-                + archiver.progress_stats.files_reencoded_count
-                + archiver.progress_stats.files_hardlink_count,
+            archiver.progress_stats.total_files_processed(),
              archiver.progress_stats.files_hardlink_count,
          );
          info!(
@@ -352,8 +358,7 @@ where
          info!("Processing summary:");
          info!(
              "- {} total files ({} hardlinks) with {} data",
-            archiver.progress_stats.files_reencoded_count
-                + archiver.progress_stats.files_hardlink_count,
+            archiver.progress_stats.total_files_processed(),
              archiver.progress_stats.files_hardlink_count,
              HumanByte::from(archiver.progress_stats.total_reencoded_size),
          );