public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Shan Shaji <s.shaji@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 8/9] docs: add explanation regarding ``rebuild-chunk-markers`` option
Date: Wed, 11 Nov 2026 16:04:57 +0100	[thread overview]
Message-ID: <861386f3-a00b-4b62-92da-840afe32bb29@proxmox.com> (raw)
In-Reply-To: <20261019160359.20851-9-s.shaji@proxmox.com>

One comment in-line.

On 10/19/26 6:04 PM, Shan Shaji wrote:
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   docs/storage.rst | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/storage.rst b/docs/storage.rst
> index 2c6ba0a85..811b5ff44 100644
> --- a/docs/storage.rst
> +++ b/docs/storage.rst
> @@ -312,8 +312,11 @@ To setup a new datastore called ``my-s3-store`` placed in a bucket called ``pbs-
>   A datastore cannot be shared between multiple Proxmox Backup Server instances, only one instance can
>   operate on the datastore at a time. However, datastore contents used on an instance which is no
>   longer available can be reused on a fresh installation. To recreate the datastore, you must pass the
> -``reuse-datastore`` and ``overwrite-in-use`` flags. Since the datastore name is used as prefix, the
> -same datastore name must be used.

comment: this deleted the important requirement that the same datastore 
name must be used.

> +``reuse-datastore`` and ``overwrite-in-use`` flags. The optional ``rebuild-chunk-markers`` flag,
> +disabled by default, creates local zero-byte chunk markers when reusing an S3 datastore. These markers
> +allow Proxmox Backup Server to identify chunks already stored in S3 when they are not present in
> +the in-memory cache, avoiding unnecessary uploads. The time required to create these markers depends
> +on the number of chunks.
>   
>   .. code-block:: console
>   





  reply	other threads:[~2026-11-11 15:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:03 [PATCH proxmox{-backup,} 0/9] fix #7903: rebuild local S3 chunk markers Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 1/9] refactor: remove local `LogThrottle` in favor of proxmox-log Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 2/9] datastore: factor out s3 chunk objects pagination into a helper Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 3/9] pbs-datastore: inherit proxmox-log crate from workspace Shan Shaji
2026-11-11 15:05   ` Christian Ebner
2026-10-19 16:03 ` [PATCH proxmox-backup 4/9] datastore: add method to create zero-byte chunk markers Shan Shaji
2026-11-11 15:04   ` Christian Ebner
2026-10-19 16:03 ` [PATCH proxmox-backup 5/9] fix #7908: datastore: api: add option " Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 6/9] fix #7908: datastore: ui: " Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 7/9] fix #7908: backup-manager: " Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 8/9] docs: add explanation regarding ``rebuild-chunk-markers`` option Shan Shaji
2026-11-11 15:04   ` Christian Ebner [this message]
2026-10-19 16:03 ` [PATCH proxmox 9/9] proxmox-log: add LogThrottle implementation Shan Shaji
2026-11-11 15:05   ` Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861386f3-a00b-4b62-92da-840afe32bb29@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal