public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 6/9] fix #7908: datastore: ui: add option to create zero-byte chunk markers
Date: Mon, 19 Oct 2026 18:03:56 +0200	[thread overview]
Message-ID: <20261019160359.20851-7-s.shaji@proxmox.com> (raw)
In-Reply-To: <20261019160359.20851-1-s.shaji@proxmox.com>

Expose the `rebuild-chunk-markers` option inside the datastore creation
window to allow creating empty, zero-byte chunk markers.

This option is disabled and can only be enabled when configuring an
S3-backed datastore.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7908
---
 www/window/DataStoreEdit.js | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index 911bf47d6..f536ec659 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -81,6 +81,9 @@ Ext.define('PBS.DataStoreEdit', {
                                 let reuseDatastore = inputPanel
                                     .down('[name=reuse-datastore]')
                                     .getValue();
+                                let rebuildChunkMarkersField = inputPanel.down(
+                                    '[name=rebuild-chunk-markers]',
+                                );
 
                                 uuidEditField.setDisabled(!isRemovable);
                                 uuidEditField.allowBlank = !isRemovable;
@@ -100,6 +103,10 @@ Ext.define('PBS.DataStoreEdit', {
                                 overwriteInUseField.setDisabled(!reuseDatastore);
                                 overwriteInUseField.setValue(false);
 
+                                rebuildChunkMarkersField.setHidden(!isS3);
+                                rebuildChunkMarkersField.setDisabled(!reuseDatastore);
+                                rebuildChunkMarkersField.setValue(false);
+
                                 if (isRemovable) {
                                     pathField.setFieldLabel(gettext('Path on Device'));
                                     pathField.setEmptyText(gettext('A relative path'));
@@ -204,6 +211,12 @@ Ext.define('PBS.DataStoreEdit', {
                                     inputPanel.down('[name=overwrite-in-use]');
                                 overwriteInUseField.setDisabled(!selected);
                                 overwriteInUseField.setValue(false);
+
+                                let rebuildChunkMarkersField = inputPanel.down(
+                                    '[name=rebuild-chunk-markers]',
+                                );
+                                rebuildChunkMarkersField.setDisabled(!selected);
+                                rebuildChunkMarkersField.setValue(false);
                             },
                         },
                     },
@@ -216,6 +229,13 @@ Ext.define('PBS.DataStoreEdit', {
                         hidden: true,
                         disabled: true,
                     },
+                    {
+                        xtype: 'checkbox',
+                        name: 'rebuild-chunk-markers',
+                        fieldLabel: gettext('Rebuild chunk markers'),
+                        hidden: true,
+                        disabled: true,
+                    },
                 ],
 
                 onGetValues: function (values) {
-- 
2.47.3





  parent reply	other threads:[~2026-10-19 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:03 [PATCH proxmox{-backup,} 0/9] fix #7903: rebuild local S3 chunk markers Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 1/9] refactor: remove local `LogThrottle` in favor of proxmox-log Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 2/9] datastore: factor out s3 chunk objects pagination into a helper Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 3/9] pbs-datastore: inherit proxmox-log crate from workspace Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 4/9] datastore: add method to create zero-byte chunk markers Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 5/9] fix #7908: datastore: api: add option " Shan Shaji
2026-10-19 16:03 ` Shan Shaji [this message]
2026-10-19 16:03 ` [PATCH proxmox-backup 7/9] fix #7908: backup-manager: " Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox-backup 8/9] docs: add explanation regarding ``rebuild-chunk-markers`` option Shan Shaji
2026-10-19 16:03 ` [PATCH proxmox 9/9] proxmox-log: add LogThrottle implementation Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019160359.20851-7-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal