From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E2EE81FF09C for ; Mon, 19 Oct 2026 18:04:31 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 03A6F21698; Mon, 19 Oct 2026 18:04:19 +0200 (CEST) From: Shan Shaji To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 6/9] fix #7908: datastore: ui: add option to create zero-byte chunk markers Date: Mon, 19 Oct 2026 18:03:56 +0200 Message-ID: <20261019160359.20851-7-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261019160359.20851-1-s.shaji@proxmox.com> References: <20261019160359.20851-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792425855273 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.403 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 76BTHIJXHKAYR4TPAYIO4CASBUTMERYR X-Message-ID-Hash: 76BTHIJXHKAYR4TPAYIO4CASBUTMERYR X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Expose the `rebuild-chunk-markers` option inside the datastore creation window to allow creating empty, zero-byte chunk markers. This option is disabled and can only be enabled when configuring an S3-backed datastore. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7908 --- www/window/DataStoreEdit.js | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js index 911bf47d6..f536ec659 100644 --- a/www/window/DataStoreEdit.js +++ b/www/window/DataStoreEdit.js @@ -81,6 +81,9 @@ Ext.define('PBS.DataStoreEdit', { let reuseDatastore = inputPanel .down('[name=reuse-datastore]') .getValue(); + let rebuildChunkMarkersField = inputPanel.down( + '[name=rebuild-chunk-markers]', + ); uuidEditField.setDisabled(!isRemovable); uuidEditField.allowBlank = !isRemovable; @@ -100,6 +103,10 @@ Ext.define('PBS.DataStoreEdit', { overwriteInUseField.setDisabled(!reuseDatastore); overwriteInUseField.setValue(false); + rebuildChunkMarkersField.setHidden(!isS3); + rebuildChunkMarkersField.setDisabled(!reuseDatastore); + rebuildChunkMarkersField.setValue(false); + if (isRemovable) { pathField.setFieldLabel(gettext('Path on Device')); pathField.setEmptyText(gettext('A relative path')); @@ -204,6 +211,12 @@ Ext.define('PBS.DataStoreEdit', { inputPanel.down('[name=overwrite-in-use]'); overwriteInUseField.setDisabled(!selected); overwriteInUseField.setValue(false); + + let rebuildChunkMarkersField = inputPanel.down( + '[name=rebuild-chunk-markers]', + ); + rebuildChunkMarkersField.setDisabled(!selected); + rebuildChunkMarkersField.setValue(false); }, }, }, @@ -216,6 +229,13 @@ Ext.define('PBS.DataStoreEdit', { hidden: true, disabled: true, }, + { + xtype: 'checkbox', + name: 'rebuild-chunk-markers', + fieldLabel: gettext('Rebuild chunk markers'), + hidden: true, + disabled: true, + }, ], onGetValues: function (values) { -- 2.47.3