public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown
Date: Tue, 25 Feb 2025 17:22:14 +0100	[thread overview]
Message-ID: <58d3277c-8ab7-4d2f-a8f8-23406acd2967@proxmox.com> (raw)
In-Reply-To: <95c31cbf-e3c7-4078-8b77-f0bed28d9b47@proxmox.com>

On 2/25/25 17:19, Thomas Lamprecht wrote:
> Am 29.11.24 um 11:41 schrieb Christian Ebner:
>> Do not allow to open the smart values window by either double clicking
>> the record or clicking the show button, if the selected drives status
>> is unknown.
>>
>> Fetching the smart values for such devices might fail. Devices which
>> do not support this can be, e.g. USB pen drives used as removable
>> datastores in Proxmox Backup Server.
>>
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/158217/
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>>   src/panel/DiskList.js | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
>> index dfd8c8e..3a1632c 100644
>> --- a/src/panel/DiskList.js
>> +++ b/src/panel/DiskList.js
>> @@ -86,6 +86,9 @@ Ext.define('Proxmox.DiskList', {
>>   	    if (!selection || selection.length < 1) return;
>>   
>>   	    let rec = selection[0];
>> +	    if (!rec.data.status || rec.data.status === Proxmox.Utils.unknownText) {
>> +		return;
>> +	    }
>>   	    Ext.create('Proxmox.window.DiskSmart', {
>>   		baseurl: view.baseurl,
>>   		dev: rec.data.name,
>> @@ -369,7 +372,8 @@ Ext.define('Proxmox.DiskList', {
>>   		parentXType: 'treepanel',
>>   		disabled: true,
>>   		enableFn: function(rec) {
>> -		    if (!rec || rec.data.parent) {
>> +		    if (!rec || rec.data.parent || !rec.data.status ||
>> +			rec.data.status === Proxmox.Utils.unknownText) {
>>   			return false;
>>   		    } else {
>>   			return true;
> 
> pre-existing but an if-else that returns boolean seldomly makes sense,
> i.e. this could be:
> 
> enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status !== Proxmox.Utils.unknownText,
> 
> or with my comment for patch 1 addressed it might be:
> 
> enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status !== 'unknown',
> 
> 
Acked, will incorporate the suggestions for both patches in a v2, thanks 
for feedback!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-02-25 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 10:41 [pbs-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status Christian Ebner
2024-11-29 10:41 ` [pbs-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown Christian Ebner
2025-02-25 16:19   ` [pbs-devel] [pve-devel] " Thomas Lamprecht
2025-02-25 16:22     ` Christian Ebner [this message]
2025-02-25 16:41       ` Thomas Lamprecht
2025-02-25 16:17 ` [pbs-devel] [pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58d3277c-8ab7-4d2f-a8f8-23406acd2967@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal