From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 759601FF15E
for <inbox@lore.proxmox.com>; Tue, 25 Feb 2025 17:22:49 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 487132A6BB;
Tue, 25 Feb 2025 17:22:48 +0100 (CET)
Message-ID: <58d3277c-8ab7-4d2f-a8f8-23406acd2967@proxmox.com>
Date: Tue, 25 Feb 2025 17:22:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
pbs-devel@lists.proxmox.com
References: <20241129104134.127763-1-c.ebner@proxmox.com>
<20241129104134.127763-2-c.ebner@proxmox.com>
<95c31cbf-e3c7-4078-8b77-f0bed28d9b47@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <95c31cbf-e3c7-4078-8b77-f0bed28d9b47@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.031 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk
list: disable show smart values button if status unknown
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On 2/25/25 17:19, Thomas Lamprecht wrote:
> Am 29.11.24 um 11:41 schrieb Christian Ebner:
>> Do not allow to open the smart values window by either double clicking
>> the record or clicking the show button, if the selected drives status
>> is unknown.
>>
>> Fetching the smart values for such devices might fail. Devices which
>> do not support this can be, e.g. USB pen drives used as removable
>> datastores in Proxmox Backup Server.
>>
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/158217/
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> src/panel/DiskList.js | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
>> index dfd8c8e..3a1632c 100644
>> --- a/src/panel/DiskList.js
>> +++ b/src/panel/DiskList.js
>> @@ -86,6 +86,9 @@ Ext.define('Proxmox.DiskList', {
>> if (!selection || selection.length < 1) return;
>>
>> let rec = selection[0];
>> + if (!rec.data.status || rec.data.status === Proxmox.Utils.unknownText) {
>> + return;
>> + }
>> Ext.create('Proxmox.window.DiskSmart', {
>> baseurl: view.baseurl,
>> dev: rec.data.name,
>> @@ -369,7 +372,8 @@ Ext.define('Proxmox.DiskList', {
>> parentXType: 'treepanel',
>> disabled: true,
>> enableFn: function(rec) {
>> - if (!rec || rec.data.parent) {
>> + if (!rec || rec.data.parent || !rec.data.status ||
>> + rec.data.status === Proxmox.Utils.unknownText) {
>> return false;
>> } else {
>> return true;
>
> pre-existing but an if-else that returns boolean seldomly makes sense,
> i.e. this could be:
>
> enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status !== Proxmox.Utils.unknownText,
>
> or with my comment for patch 1 addressed it might be:
>
> enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status !== 'unknown',
>
>
Acked, will incorporate the suggestions for both patches in a v2, thanks
for feedback!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel