From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] superseded: Re: [PATCH proxmox/proxmox-backup v2 0/8] trigger sync jobs on mount
Date: Wed, 4 Jun 2025 14:32:57 +0200 [thread overview]
Message-ID: <47d9aaec-b8f7-4852-ac7f-e550044f7df6@proxmox.com> (raw)
In-Reply-To: <20250515124138.55436-1-h.laimer@proxmox.com>
superseded by:
https://lore.proxmox.com/pbs-devel/20250604123054.87007-1-h.laimer@proxmox.com/T/#m9a65d2b7f58ada01d6394bb96391fea62ab444b9
On 5/15/25 14:41, Hannes Laimer wrote:
> Sync jobs now have a run-on-mount flag, that, if set, runs the job whenever
> a relevant removable datastore is mounted.
>
> This depends on [1], without it the api process does not drop the file
> handle on the `.lock` file which leads to the datastore being not
> unmountable after sync jobs were triggered. (now thinking about it,
> might have made sense to include it in this series directly, but it also
> does make sense on its own)
>
> v2, thanks @Chris:
> - rebased onto master
> - improve some docstrings
> - move/fix config flag
> - drop not-needed changes for the manager binary
> - ui: move checkbox to advenced section + don't clear schedule field
> - fix test
> - actually check the configured flag when deciding if a job should
> run...
>
> [1] https://lore.proxmox.com/pbs-devel/20250512125933.156192-1-h.laimer@proxmox.com/T/#u
>
>
> proxmox:
> Hannes Laimer (2):
> rest-server: add function that returns a join handle for spawn
> pbs-api-types: add run-on-mount flag to SyncJobConfig
>
> pbs-api-types/src/jobs.rs | 8 ++++++++
> proxmox-rest-server/src/worker_task.rs | 24 ++++++++++++++++++++++--
> 2 files changed, 30 insertions(+), 2 deletions(-)
>
> proxmox-backup:
> Hannes Laimer (6):
> api: config: sync: update run-on-mount correctly
> api: admin: run configured sync jobs when a datastore is mounted
> api: admin: trigger sync jobs only on datastore mount
> bin: manager: run uuid_mount/mount tasks on the proxy
> ui: add run-on-mount checkbox to SyncJob form
> ui: add task title for triggering sync jobs
>
> src/api2/admin/datastore.rs | 97 +++++++++++++++++++--
> src/api2/admin/sync.rs | 2 +-
> src/api2/config/sync.rs | 9 ++
> src/bin/proxmox_backup_manager/datastore.rs | 41 ++++++---
> src/server/sync.rs | 7 +-
> www/Utils.js | 1 +
> www/window/SyncJobEdit.js | 13 ++-
> 7 files changed, 148 insertions(+), 22 deletions(-)
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-06-04 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:41 [pbs-devel] " Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox v2 1/8] rest-server: add function that returns a join handle for spawn Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox v2 2/8] pbs-api-types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 3/8] api: config: sync: update run-on-mount correctly Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 4/8] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-05-30 10:02 ` Christian Ebner
2025-05-30 11:45 ` Hannes Laimer
2025-05-30 13:08 ` Christian Ebner
2025-06-04 12:22 ` Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 5/8] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 6/8] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 7/8] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-05-15 12:41 ` [pbs-devel] [PATCH proxmox-backup v2 8/8] ui: add task title for triggering sync jobs Hannes Laimer
2025-06-04 12:32 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d9aaec-b8f7-4852-ac7f-e550044f7df6@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal