Re: [PATCH proxmox 1/3] fix #6121: network-api: api: add `bond-miimon` option for interfaces

[Christian Ebner <c.ebner@proxmox.com>]

one question inline.

On 9/25/26 2:35 PM, Christoph Heiss wrote:
> Partially fixes #6121 [0].
> 
> Adds a new 'bond-miimon' option to the network interface API for
> specifying the link monitoring interval.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6121
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>   proxmox-network-api/src/api_impl.rs  |  9 +++++++++
>   proxmox-network-api/src/api_types.rs | 18 ++++++++++++++++++
>   2 files changed, 27 insertions(+)
> 
> diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs
> index 78f499c5..0a603017 100644
> --- a/proxmox-network-api/src/api_impl.rs
> +++ b/proxmox-network-api/src/api_impl.rs
> @@ -162,6 +162,9 @@ pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), E
>                       interface.bond_xmit_hash_policy = config.bond_xmit_hash_policy;
>                   }
>               }
> +            if config.bond_miimon.is_some() {
> +                interface.bond_miimon = config.bond_miimon;
> +            }
>               if let Some(slaves) = &config.slaves {
>                   interface.set_bond_slave_list(slaves)?;
>               }
> @@ -295,6 +298,9 @@ pub fn update_interface(
>                   DeletableInterfaceProperty::BondXmitHashPolicy => {
>                       interface.bond_xmit_hash_policy = None
>                   }
> +                DeletableInterfaceProperty::BondMiimon => {
> +                    interface.bond_miimon = None;
> +                }
>               }
>           }
>       }
> @@ -335,6 +341,9 @@ pub fn update_interface(
>               }
>               interface.bond_xmit_hash_policy = update.bond_xmit_hash_policy;
>           }
> +        if update.bond_miimon.is_some() {
> +            interface.bond_miimon = update.bond_miimon;
> +        }
>       }
>   
>       if let Some(cidr) = update.cidr {
> diff --git a/proxmox-network-api/src/api_types.rs b/proxmox-network-api/src/api_types.rs
> index f2467f1e..471f20e8 100644
> --- a/proxmox-network-api/src/api_types.rs
> +++ b/proxmox-network-api/src/api_types.rs
> @@ -228,6 +228,12 @@ pub const NETWORK_INTERFACE_LIST_SCHEMA: Schema =
>               type: BondXmitHashPolicy,
>               optional: true,
>           },
> +        "bond-miimon": {
> +            description: "Link monitoring interval in milliseconds for bond interfaces.",
> +            type: u8,

isn't this to restrictive?

At least the Kernel seem to accept larger values AFAICT:
- 
https://github.com/torvalds/linux/blob/master/drivers/net/bonding/bond_options.c#L149
- 
https://github.com/torvalds/linux/blob/master/drivers/net/bonding/bond_main.c#L6174

> +            optional: true,
> +            default: 100,
> +        },
>           altnames: {
>               description: "List of altnames for this interface",
>               type: Array,
> @@ -302,6 +308,8 @@ pub struct Interface {
>       pub bond_primary: Option<String>,
>       #[serde(skip_serializing_if = "Option::is_none")]
>       pub bond_xmit_hash_policy: Option<BondXmitHashPolicy>,
> +    #[serde(rename = "bond-miimon", skip_serializing_if = "Option::is_none")]
> +    pub bond_miimon: Option<u8>,
>   
>       #[serde(default, skip_serializing_if = "Vec::is_empty")]
>       pub altnames: Vec<String>,
> @@ -333,6 +341,7 @@ impl Interface {
>               bond_mode: None,
>               bond_primary: None,
>               bond_xmit_hash_policy: None,
> +            bond_miimon: None,
>               altnames: Vec::new(),
>           }
>       }
> @@ -425,6 +434,8 @@ pub enum DeletableInterfaceProperty {
>       /// Delete bond transmit hash policy
>       #[serde(rename = "bond_xmit_hash_policy")]
>       BondXmitHashPolicy,
> +    /// Delete bond miimon (set to default 100)
> +    BondMiimon,
>   }
>   
>   #[api(
> @@ -509,6 +520,12 @@ pub enum DeletableInterfaceProperty {
>                   type: BondXmitHashPolicy,
>                   optional: true,
>               },
> +            "bond-miimon": {
> +                description: "Link monitoring interval in milliseconds for bond interfaces.",
> +                type: u8,
> +                optional: true,
> +                default: 100,
> +            },
>               slaves: {
>                   schema: NETWORK_INTERFACE_LIST_SCHEMA,
>                   optional: true,
> @@ -542,5 +559,6 @@ pub struct InterfaceUpdater {
>       pub bond_primary: Option<String>,
>       #[serde(rename = "bond_xmit_hash_policy")]
>       pub bond_xmit_hash_policy: Option<BondXmitHashPolicy>,
> +    pub bond_miimon: Option<u8>,
>       pub slaves: Option<String>,
>   }