From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EC82B1FF09B for ; Mon, 09 Nov 2026 11:15:35 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 841172132E; Mon, 09 Nov 2026 11:15:35 +0100 (CET) Message-ID: <37db266f-b721-4f04-b6d8-4e4add78badc@proxmox.com> Date: Mon, 9 Nov 2026 11:15:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox 1/3] fix #6121: network-api: api: add `bond-miimon` option for interfaces To: Christoph Heiss , pbs-devel@lists.proxmox.com References: <20260925123459.424903-1-c.heiss@proxmox.com> <20260925123459.424903-2-c.heiss@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260925123459.424903-2-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794219330875 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.437 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZH7EK5VHQEOBDJZGO4UNXBA7ZSMJJO43 X-Message-ID-Hash: ZH7EK5VHQEOBDJZGO4UNXBA7ZSMJJO43 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: one question inline. On 9/25/26 2:35 PM, Christoph Heiss wrote: > Partially fixes #6121 [0]. > > Adds a new 'bond-miimon' option to the network interface API for > specifying the link monitoring interval. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6121 > > Signed-off-by: Christoph Heiss > --- > proxmox-network-api/src/api_impl.rs | 9 +++++++++ > proxmox-network-api/src/api_types.rs | 18 ++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs > index 78f499c5..0a603017 100644 > --- a/proxmox-network-api/src/api_impl.rs > +++ b/proxmox-network-api/src/api_impl.rs > @@ -162,6 +162,9 @@ pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), E > interface.bond_xmit_hash_policy = config.bond_xmit_hash_policy; > } > } > + if config.bond_miimon.is_some() { > + interface.bond_miimon = config.bond_miimon; > + } > if let Some(slaves) = &config.slaves { > interface.set_bond_slave_list(slaves)?; > } > @@ -295,6 +298,9 @@ pub fn update_interface( > DeletableInterfaceProperty::BondXmitHashPolicy => { > interface.bond_xmit_hash_policy = None > } > + DeletableInterfaceProperty::BondMiimon => { > + interface.bond_miimon = None; > + } > } > } > } > @@ -335,6 +341,9 @@ pub fn update_interface( > } > interface.bond_xmit_hash_policy = update.bond_xmit_hash_policy; > } > + if update.bond_miimon.is_some() { > + interface.bond_miimon = update.bond_miimon; > + } > } > > if let Some(cidr) = update.cidr { > diff --git a/proxmox-network-api/src/api_types.rs b/proxmox-network-api/src/api_types.rs > index f2467f1e..471f20e8 100644 > --- a/proxmox-network-api/src/api_types.rs > +++ b/proxmox-network-api/src/api_types.rs > @@ -228,6 +228,12 @@ pub const NETWORK_INTERFACE_LIST_SCHEMA: Schema = > type: BondXmitHashPolicy, > optional: true, > }, > + "bond-miimon": { > + description: "Link monitoring interval in milliseconds for bond interfaces.", > + type: u8, isn't this to restrictive? At least the Kernel seem to accept larger values AFAICT: - https://github.com/torvalds/linux/blob/master/drivers/net/bonding/bond_options.c#L149 - https://github.com/torvalds/linux/blob/master/drivers/net/bonding/bond_main.c#L6174 > + optional: true, > + default: 100, > + }, > altnames: { > description: "List of altnames for this interface", > type: Array, > @@ -302,6 +308,8 @@ pub struct Interface { > pub bond_primary: Option, > #[serde(skip_serializing_if = "Option::is_none")] > pub bond_xmit_hash_policy: Option, > + #[serde(rename = "bond-miimon", skip_serializing_if = "Option::is_none")] > + pub bond_miimon: Option, > > #[serde(default, skip_serializing_if = "Vec::is_empty")] > pub altnames: Vec, > @@ -333,6 +341,7 @@ impl Interface { > bond_mode: None, > bond_primary: None, > bond_xmit_hash_policy: None, > + bond_miimon: None, > altnames: Vec::new(), > } > } > @@ -425,6 +434,8 @@ pub enum DeletableInterfaceProperty { > /// Delete bond transmit hash policy > #[serde(rename = "bond_xmit_hash_policy")] > BondXmitHashPolicy, > + /// Delete bond miimon (set to default 100) > + BondMiimon, > } > > #[api( > @@ -509,6 +520,12 @@ pub enum DeletableInterfaceProperty { > type: BondXmitHashPolicy, > optional: true, > }, > + "bond-miimon": { > + description: "Link monitoring interval in milliseconds for bond interfaces.", > + type: u8, > + optional: true, > + default: 100, > + }, > slaves: { > schema: NETWORK_INTERFACE_LIST_SCHEMA, > optional: true, > @@ -542,5 +559,6 @@ pub struct InterfaceUpdater { > pub bond_primary: Option, > #[serde(rename = "bond_xmit_hash_policy")] > pub bond_xmit_hash_policy: Option, > + pub bond_miimon: Option, > pub slaves: Option, > }