From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 09/10] bin: debug: use pxar related archive name helpers for diff
Date: Tue, 17 Nov 2026 16:28:13 +0100 [thread overview]
Message-ID: <20261117152814.491323-10-c.ebner@proxmox.com> (raw)
In-Reply-To: <20261117152814.491323-1-c.ebner@proxmox.com>
Reuses the helpers to check for archive name extensions and archive
name completions used by the client and server for keeping
implementation details in sync.
Also, mention mpxar/ppxar extensions being supported when bailing.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
src/bin/proxmox_backup_debug/diff.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bin/proxmox_backup_debug/diff.rs b/src/bin/proxmox_backup_debug/diff.rs
index cef4af68d..a8fe73b4f 100644
--- a/src/bin/proxmox_backup_debug/diff.rs
+++ b/src/bin/proxmox_backup_debug/diff.rs
@@ -20,7 +20,7 @@ use pbs_client::tools::key_source::{
get_encryption_key_password,
};
use pbs_client::tools::{
- complete_archive_name, complete_group_or_snapshot, connect, extract_repository_from_value,
+ complete_group_or_snapshot, complete_pxar_archive_name, connect, extract_repository_from_value,
get_pxar_archive_names, optional_ns_param,
};
use pbs_client::{BackupReader, BackupRepository, BackupTargetArgs, RemoteChunkReader};
@@ -51,7 +51,7 @@ pub fn diff_commands() -> CommandLineInterface {
.arg_param(&["prev-snapshot", "snapshot", "archive-name"])
.completion_cb("prev-snapshot", complete_group_or_snapshot)
.completion_cb("snapshot", complete_group_or_snapshot)
- .completion_cb("archive-name", complete_archive_name),
+ .completion_cb("archive-name", complete_pxar_archive_name),
);
cmd_def.into()
@@ -141,7 +141,7 @@ async fn diff_archive_cmd(
let output_params = OutputParams { color };
- if archive_name.ends_with(".pxar.didx") {
+ if archive_name.has_pxar_filename_extension() {
diff_archive(
&prev_snapshot,
&snapshot,
@@ -152,7 +152,7 @@ async fn diff_archive_cmd(
)
.await?;
} else {
- bail!("Only .pxar files are supported");
+ bail!("Only .pxar, .mpxar and .ppxar files are supported");
}
Ok(())
--
2.47.3
next prev parent reply other threads:[~2026-11-17 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 15:28 [PATCH proxmox-backup/pxar 00/10] fix #8319: support split pxar archives in proxmox-backup-debug diff Christian Ebner
2026-11-17 15:28 ` [PATCH pxar 01/10] encoder: record metadata-only goodbye size for split archive files Christian Ebner
2026-11-17 15:28 ` [PATCH pxar 02/10] accessor: limit split archive file entry ranges to payload reference Christian Ebner
2026-11-17 15:28 ` [PATCH pxar 03/10] accessor: add convenience helper to get content's byte range Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 04/10] datastore: index: return dedicated type for chunk offset trait method Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 05/10] bin: debug: fix off-by-one error in last chunk lookup Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 06/10] bin: debug: refactore dynamic index reader opening logic into helper Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 07/10] bin: debug: refactor and deduplicate chunk range difference check Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 08/10] fix #8319: bin: debug: support split pxar archives via diff Christian Ebner
2026-11-17 15:28 ` Christian Ebner [this message]
2026-11-17 15:28 ` [PATCH proxmox-backup 10/10] docs: debug: mention split pxar archives for diff subcommand Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117152814.491323-10-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox