public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup/pxar 00/10] fix #8319: support split pxar archives in proxmox-backup-debug diff
Date: Tue, 17 Nov 2026 16:28:04 +0100	[thread overview]
Message-ID: <20261117152814.491323-1-c.ebner@proxmox.com> (raw)

Support for split pxar archives has not yet been implemented for
proxmox-backup-debug diff.

This patch series fixes an encoding and decoding issues with entry
ranges in pxar encountered during implementation and an off-by-one
error for chunk lookup with range end in the current implementation
of the archive diff, followed by some preliminary refactoring to
ease subsequent implementation. Then support for the split meta-/
payload-data archives is added.

For split pxar archives the goodbye table still incorrectly encoded
the size to include the file payload size of a referenced file entry.
It however is not part of the metadata archive, must therefore be
excluded. The entry range is now trimmed to the actual range in the
metadata archive, keeping backwards compatibility.

Metadata and payload data index files are opened and compared like
regular files, with a crucial difference: Since no changes in
metadata archives do not necessarily imply no change in payload
archive, the chunks for both are tracked independently, and contents
changes are being checked even if the metadata chunks are unchanged,
give the compare-contents flag.

Link to the bugtracker:
https://bugzilla.proxmox.com/show_bug.cgi?id=8319


pxar:

Christian Ebner (3):
  encoder: record metadata-only goodbye size for split archive files
  accessor: limit split archive file entry ranges to payload reference
  accessor: add convenience helper to get content's byte range

 Cargo.toml          |   6 ++
 src/accessor/mod.rs |  39 ++++++--
 src/encoder/mod.rs  |   9 +-
 tests/split.rs      | 220 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 265 insertions(+), 9 deletions(-)
 create mode 100644 tests/split.rs


proxmox-backup:

Christian Ebner (7):
  datastore: index: return dedicated type for chunk offset trait method
  bin: debug: fix off-by-one error in last chunk lookup
  bin: debug: refactore dynamic index reader opening logic into helper
  bin: debug: refactor and deduplicate chunk range difference check
  fix #8319: bin: debug: support split pxar archives via diff
  bin: debug: use pxar related archive name helpers for diff
  docs: debug: mention split pxar archives for diff subcommand

 docs/proxmox-backup-debug/description.rst |   5 +-
 pbs-datastore/src/cached_chunk_reader.rs  |   9 +-
 pbs-datastore/src/dynamic_index.rs        |   9 +-
 pbs-datastore/src/fixed_index.rs          |  12 +-
 pbs-datastore/src/index.rs                |  11 +-
 src/bin/proxmox_backup_debug/diff.rs      | 299 ++++++++++++++++------
 6 files changed, 253 insertions(+), 92 deletions(-)


Summary over all repositories:
  10 files changed, 518 insertions(+), 101 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-17 15:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:28 Christian Ebner [this message]
2026-11-17 15:28 ` [PATCH pxar 01/10] encoder: record metadata-only goodbye size for split archive files Christian Ebner
2026-11-17 15:28 ` [PATCH pxar 02/10] accessor: limit split archive file entry ranges to payload reference Christian Ebner
2026-11-17 15:28 ` [PATCH pxar 03/10] accessor: add convenience helper to get content's byte range Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 04/10] datastore: index: return dedicated type for chunk offset trait method Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 05/10] bin: debug: fix off-by-one error in last chunk lookup Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 06/10] bin: debug: refactore dynamic index reader opening logic into helper Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 07/10] bin: debug: refactor and deduplicate chunk range difference check Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 08/10] fix #8319: bin: debug: support split pxar archives via diff Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 09/10] bin: debug: use pxar related archive name helpers for diff Christian Ebner
2026-11-17 15:28 ` [PATCH proxmox-backup 10/10] docs: debug: mention split pxar archives for diff subcommand Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117152814.491323-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal