From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 proxmox-backup 2/8] tape: fix clippy::question_mark
Date: Tue, 3 Nov 2026 12:28:38 +0100 [thread overview]
Message-ID: <20261103113054.184327-3-r.obkircher@proxmox.com> (raw)
In-Reply-To: <20261103113054.184327-1-r.obkircher@proxmox.com>
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
pbs-tape/src/blocked_writer.rs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/pbs-tape/src/blocked_writer.rs b/pbs-tape/src/blocked_writer.rs
index 7380af243..d0f64473e 100644
--- a/pbs-tape/src/blocked_writer.rs
+++ b/pbs-tape/src/blocked_writer.rs
@@ -98,10 +98,8 @@ impl<W: BlockWrite> BlockedWriter<W> {
impl<W: BlockWrite> TapeWrite for BlockedWriter<W> {
fn write_all(&mut self, mut data: &[u8]) -> Result<bool, std::io::Error> {
while !data.is_empty() {
- match self.write(data) {
- Ok(n) => data = &data[n..],
- Err(e) => return Err(e),
- }
+ let n = self.write(data)?;
+ data = &data[n..]
}
Ok(self.logical_end_of_media)
}
--
2.47.3
next prev parent reply other threads:[~2026-11-03 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:28 [PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 1/8] tree-wide: fix clippy::useless_borrows_in_formatting Robert Obkircher
2026-11-03 11:28 ` Robert Obkircher [this message]
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 3/8] api: fix clippy::unnecessary_lazy_evaluations Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 4/8] cargo: update minimum rust version to 1.91 Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 5/8] tree-wide: mark extern blocks as unsafe and add some safety comments Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 6/8] tree-wide: remove redundant ref keyword in pattern matches Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 7/8] tree-wide: add empty use<> bounds to return position impl traits Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 8/8] cargo: remove unused dependencies Robert Obkircher
2026-11-05 11:07 ` applied-series: [PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103113054.184327-3-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox