[PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities

[Robert Obkircher <r.obkircher@proxmox.com>]

Apply some clippy suggestions, prepare for a future edition upgrade,
and remove unused dependencies.

To upgrade to the 2024 edition, we would still have to wrap some
std::env functions in unsafe, and review countless drop order warnings
reported by `cargo fix --edition`.


Robert Obkircher (8):
  tree-wide: fix clippy::useless_borrows_in_formatting
  tape: fix clippy::question_mark
  api: fix clippy::unnecessary_lazy_evaluations
  cargo: update minimum rust version to 1.91
  tree-wide: mark extern blocks as unsafe and add some safety comments
  tree-wide: remove redundant ref keyword in pattern matches
  tree-wide: add empty use<> bounds to return position impl traits
  cargo: remove unused dependencies

 Cargo.toml                               |  8 +-------
 debian/control                           |  1 -
 pbs-client/src/catalog_shell.rs          |  2 +-
 pbs-client/src/http_client.rs            |  2 +-
 pbs-client/src/pxar/extract.rs           |  2 +-
 pbs-tape/src/blocked_writer.rs           |  6 ++----
 pbs-tape/src/sgutils2.rs                 | 19 ++++++++++++++++---
 pbs-tools/src/cert.rs                    |  6 +++++-
 proxmox-file-restore/src/block_driver.rs |  2 +-
 src/api2/access/mod.rs                   |  2 +-
 src/api2/admin/datastore.rs              |  4 ++--
 src/api2/config/datastore.rs             |  2 +-
 src/api2/config/sync.rs                  |  2 +-
 src/api2/node/disks/directory.rs         |  2 +-
 src/api2/node/disks/zfs.rs               |  2 +-
 src/api2/node/services.rs                |  2 +-
 src/api2/node/tasks.rs                   |  7 +++----
 src/server/verify_job.rs                 |  2 +-
 src/tape/inventory.rs                    | 10 ++++------
 src/tape/media_pool.rs                   |  2 +-
 src/tape/media_set.rs                    |  2 +-
 21 files changed, 46 insertions(+), 41 deletions(-)

-- 
2.47.3