From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes
Date: Fri, 9 Oct 2026 16:53:12 +0200 [thread overview]
Message-ID: <20261009145328.281554-4-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261009145328.281554-1-j.theisen@proxmox.com>
This commit aligns the already existing "Enabled" checkbox in
the Prune Job Edit window to the other checkboxes.
Meaning a reword from "Enabled" to "Enable" as it is more common
throghout the UI and the disabling of the schedule field if the
checkbox is off.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
www/window/PruneJobEdit.js | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index a3dafde21..2eb8c7129 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -43,6 +43,15 @@ Ext.define('PBS.window.PruneJobEdit', {
},
},
+ setValues: function (values) {
+ let me = this;
+
+ if (!values.schedule || values.schedule === '') {
+ values.disable = true;
+ }
+ me.callParent([values]);
+ },
+
items: {
xtype: 'inputpanel',
onGetValues: function (values) {
@@ -118,11 +127,19 @@ Ext.define('PBS.window.PruneJobEdit', {
},
{
xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Enabled'),
+ fieldLabel: gettext('Enable'),
name: 'enable',
uncheckedValue: 0,
defaultValue: 1,
checked: true,
+ listeners: {
+ change: function (field, enabled) {
+ let me = this;
+ let view = me.up('pbsPruneJobEdit');
+ let schedule = view.down('field[name=schedule]');
+ schedule.setDisabled(!enabled);
+ },
+ },
},
],
--
2.47.3
next prev parent reply other threads:[~2026-10-09 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:53 [PATCH proxmox{,-backup} v3 00/10] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-10-09 14:53 ` [PATCH proxmox v3 01/10] fix #7904: Add 'disable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-09 14:53 ` [PATCH proxmox v3 02/10] pbs-api-types: prune job: make schedule optional Jonas Theisen
2026-10-09 14:53 ` Jonas Theisen [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-09 14:54 [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009145328.281554-4-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox