From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 58B561FF0B0 for ; Fri, 09 Oct 2026 16:53:52 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 276182166D; Fri, 09 Oct 2026 16:53:52 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes Date: Fri, 9 Oct 2026 16:53:12 +0200 Message-ID: <20261009145328.281554-4-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261009145328.281554-1-j.theisen@proxmox.com> References: <20261009145328.281554-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791557627284 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.167 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BCF54NY7Y63BZT342Q7VRVXCB5KIBUX4 X-Message-ID-Hash: BCF54NY7Y63BZT342Q7VRVXCB5KIBUX4 X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This commit aligns the already existing "Enabled" checkbox in the Prune Job Edit window to the other checkboxes. Meaning a reword from "Enabled" to "Enable" as it is more common throghout the UI and the disabling of the schedule field if the checkbox is off. Signed-off-by: Jonas Theisen --- www/window/PruneJobEdit.js | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js index a3dafde21..2eb8c7129 100644 --- a/www/window/PruneJobEdit.js +++ b/www/window/PruneJobEdit.js @@ -43,6 +43,15 @@ Ext.define('PBS.window.PruneJobEdit', { }, }, + setValues: function (values) { + let me = this; + + if (!values.schedule || values.schedule === '') { + values.disable = true; + } + me.callParent([values]); + }, + items: { xtype: 'inputpanel', onGetValues: function (values) { @@ -118,11 +127,19 @@ Ext.define('PBS.window.PruneJobEdit', { }, { xtype: 'proxmoxcheckbox', - fieldLabel: gettext('Enabled'), + fieldLabel: gettext('Enable'), name: 'enable', uncheckedValue: 0, defaultValue: 1, checked: true, + listeners: { + change: function (field, enabled) { + let me = this; + let view = me.up('pbsPruneJobEdit'); + let schedule = view.down('field[name=schedule]'); + schedule.setDisabled(!enabled); + }, + }, }, ], -- 2.47.3