public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{,-backup} v2 0/6] fix #7904: Implement Enable checkboxes for all jobs
Date: Wed,  7 Oct 2026 15:43:48 +0200	[thread overview]
Message-ID: <20261007134500.323872-1-j.theisen@proxmox.com> (raw)

Goal of this patch series is to allow users to disable tasks
without having to remove their current schedule.
This was already possible for Prune jobs.

Backwards compatibiltiy was kept in mind so that existing
jobs wiithout schedules would not need manual intervention.
They will get updated and adapt the new scheme on the next
actual user change.

The "remove clear" patch is to be considered optional as it does not
interfere with the functionality of the checkboxes but was rather
added from a personal perspective that this would improve UX.

Thanks for the review and help off-list @n.frey!

changes from v1:
 * Refeactored match functinos with unwrap_or()
 * Reordered and merged patches
 * Applied renderer to prune jobs as well

proxmox:

Jonas Theisen (1):
  fix #7904: Add 'enable' to {sync,verify,tape,gc} job schema and
    datastore config

 pbs-api-types/src/datastore.rs | 12 ++++++++++++
 pbs-api-types/src/jobs.rs      | 24 ++++++++++++++++++++++++
 2 files changed, 36 insertions(+)


proxmox-backup:

Jonas Theisen (5):
  ui: prune job: Align Prune Edit window to other "Enable" checkboxes
  fix #7904: api: implement "enable" for {sync,verify,tape,GC} jobs
  fix #7904: ui: job edit: introduce "Enable" checkbox for
    {sync,verify,tape,GC} jobs
  ui: Improve visibility of disabled {sync,verify,tape,GC,prune} jobs on
    the overview page
  ui: calendar-event: Remove clear button from calendar selector

 src/api2/admin/datastore.rs      |  1 +
 src/api2/admin/gc.rs             | 13 ++++++++++-
 src/api2/admin/sync.rs           |  8 ++++++-
 src/api2/admin/verify.rs         |  8 ++++++-
 src/api2/config/datastore.rs     |  4 ++++
 src/api2/config/sync.rs          |  4 ++++
 src/api2/config/verify.rs        |  3 +++
 src/api2/tape/backup.rs          |  7 +++++-
 src/bin/proxmox-backup-proxy.rs  | 20 ++++++++++++++++
 www/Utils.js                     | 10 ++++++++
 www/config/GCView.js             |  4 +++-
 www/config/PruneView.js          |  1 +
 www/config/SyncView.js           |  2 ++
 www/config/VerifyView.js         |  2 ++
 www/form/CalendarEvent.js        | 19 ----------------
 www/tape/BackupJobs.js           |  2 ++
 www/tape/window/TapeBackupJob.js | 30 ++++++++++++++++++++++--
 www/window/GCJobEdit.js          | 39 ++++++++++++++++++++++++++++----
 www/window/PruneJobEdit.js       | 10 +++++++-
 www/window/SyncJobEdit.js        | 26 +++++++++++++++++++--
 www/window/VerifyJobEdit.js      | 30 ++++++++++++++++++++++--
 21 files changed, 207 insertions(+), 36 deletions(-)


Summary over all repositories:
  23 files changed, 243 insertions(+), 36 deletions(-)

-- 
Generated by murpp 0.12.1




             reply	other threads:[~2026-10-07 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 13:43 Jonas Theisen [this message]
2026-10-07 13:43 ` [PATCH proxmox v2 1/6] fix #7904: Add 'enable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-07 13:43 ` [PATCH proxmox-backup v2 2/6] ui: prune job: Align Prune Edit window to other "Enable" checkboxes Jonas Theisen
2026-10-07 13:43 ` [PATCH proxmox-backup v2 3/6] fix #7904: api: implement "enable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-07 13:43 ` [PATCH proxmox-backup v2 4/6] fix #7904: ui: job edit: introduce "Enable" checkbox " Jonas Theisen
2026-10-07 13:43 ` [PATCH proxmox-backup v2 5/6] ui: Improve visibility of disabled {sync,verify,tape,GC,prune} jobs on the overview page Jonas Theisen
2026-10-07 13:43 ` [PATCH proxmox-backup v2 6/6] ui: calendar-event: Remove clear button from calendar selector Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007134500.323872-1-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal