From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A80CB1FF0AB for ; Wed, 07 Oct 2026 15:45:16 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5619221251; Wed, 07 Oct 2026 15:45:16 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{,-backup} v2 0/6] fix #7904: Implement Enable checkboxes for all jobs Date: Wed, 7 Oct 2026 15:43:48 +0200 Message-ID: <20261007134500.323872-1-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791380710151 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.193 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TIQPCC7TLBCEHHVHX5NGLKOMXIGSUECU X-Message-ID-Hash: TIQPCC7TLBCEHHVHX5NGLKOMXIGSUECU X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Goal of this patch series is to allow users to disable tasks without having to remove their current schedule. This was already possible for Prune jobs. Backwards compatibiltiy was kept in mind so that existing jobs wiithout schedules would not need manual intervention. They will get updated and adapt the new scheme on the next actual user change. The "remove clear" patch is to be considered optional as it does not interfere with the functionality of the checkboxes but was rather added from a personal perspective that this would improve UX. Thanks for the review and help off-list @n.frey! changes from v1: * Refeactored match functinos with unwrap_or() * Reordered and merged patches * Applied renderer to prune jobs as well proxmox: Jonas Theisen (1): fix #7904: Add 'enable' to {sync,verify,tape,gc} job schema and datastore config pbs-api-types/src/datastore.rs | 12 ++++++++++++ pbs-api-types/src/jobs.rs | 24 ++++++++++++++++++++++++ 2 files changed, 36 insertions(+) proxmox-backup: Jonas Theisen (5): ui: prune job: Align Prune Edit window to other "Enable" checkboxes fix #7904: api: implement "enable" for {sync,verify,tape,GC} jobs fix #7904: ui: job edit: introduce "Enable" checkbox for {sync,verify,tape,GC} jobs ui: Improve visibility of disabled {sync,verify,tape,GC,prune} jobs on the overview page ui: calendar-event: Remove clear button from calendar selector src/api2/admin/datastore.rs | 1 + src/api2/admin/gc.rs | 13 ++++++++++- src/api2/admin/sync.rs | 8 ++++++- src/api2/admin/verify.rs | 8 ++++++- src/api2/config/datastore.rs | 4 ++++ src/api2/config/sync.rs | 4 ++++ src/api2/config/verify.rs | 3 +++ src/api2/tape/backup.rs | 7 +++++- src/bin/proxmox-backup-proxy.rs | 20 ++++++++++++++++ www/Utils.js | 10 ++++++++ www/config/GCView.js | 4 +++- www/config/PruneView.js | 1 + www/config/SyncView.js | 2 ++ www/config/VerifyView.js | 2 ++ www/form/CalendarEvent.js | 19 ---------------- www/tape/BackupJobs.js | 2 ++ www/tape/window/TapeBackupJob.js | 30 ++++++++++++++++++++++-- www/window/GCJobEdit.js | 39 ++++++++++++++++++++++++++++---- www/window/PruneJobEdit.js | 10 +++++++- www/window/SyncJobEdit.js | 26 +++++++++++++++++++-- www/window/VerifyJobEdit.js | 30 ++++++++++++++++++++++-- 21 files changed, 207 insertions(+), 36 deletions(-) Summary over all repositories: 23 files changed, 243 insertions(+), 36 deletions(-) -- Generated by murpp 0.12.1