[PATCH proxmox v2 02/13] pbs-api-types: use match statement for maintenance mode check

[Robert Obkircher <r.obkircher@proxmox.com>]

Use an exhaustive match statement to be more explicit and to draw
attention when new variants are added.

Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
 pbs-api-types/src/maintenance.rs | 35 ++++++++++++++++----------------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs
index 2adb5d84..9a1729f4 100644
--- a/pbs-api-types/src/maintenance.rs
+++ b/pbs-api-types/src/maintenance.rs
@@ -94,25 +94,24 @@ impl MaintenanceMode {
     }
 
     pub fn check(&self, operation: Operation) -> Result<(), Error> {
-        if self.ty == MaintenanceType::Delete {
-            bail!("datastore is being deleted");
-        }
-
-        let message = percent_encoding::percent_decode_str(self.message.as_deref().unwrap_or(""))
-            .decode_utf8()
-            .unwrap_or(Cow::Borrowed(""));
+        let message = || {
+            percent_encoding::percent_decode_str(self.message.as_deref().unwrap_or(""))
+                .decode_utf8()
+                .unwrap_or(Cow::Borrowed(""))
+        };
 
-        if Operation::Lookup == operation {
-            return Ok(());
-        } else if self.ty == MaintenanceType::Unmount {
-            bail!("datastore is being unmounted");
-        } else if self.ty == MaintenanceType::Offline {
-            bail!("offline maintenance mode: {}", message);
-        } else if self.ty == MaintenanceType::S3Refresh {
-            bail!("S3 refresh maintenance mode: {}", message);
-        } else if self.ty == MaintenanceType::ReadOnly && Operation::Write == operation {
-            bail!("read-only maintenance mode: {}", message);
+        match (self.ty, operation) {
+            (MaintenanceType::Delete, _) => bail!("datastore is being deleted"),
+            (_, Operation::Lookup) => Ok(()),
+            (MaintenanceType::Unmount, _) => bail!("datastore is being unmounted"),
+            (MaintenanceType::Offline, _) => bail!("offline maintenance mode: {}", message()),
+            (MaintenanceType::S3Refresh, _) => bail!("S3 refresh maintenance mode: {}", message()),
+            (MaintenanceType::ReadOnly, Operation::Read) => Ok(()),
+            (MaintenanceType::ReadOnly, Operation::Write) => {
+                bail!("read-only maintenance mode: {}", message())
+            }
+            #[cfg(feature = "enum-fallback")]
+            (MaintenanceType::UnknownEnumValue(_), _) => Ok(()),
         }
-        Ok(())
     }
 }
-- 
2.47.3