[PATCH proxmox v2 01/13] pbs-api-types: propagate maintenance mode parse errors

[Robert Obkircher <r.obkircher@proxmox.com>]

Do not silently ignore errors if the config file is invalid or
contains an unrecognized mode from a future version. This also applies
to set_maintenance_mode, which could previously override such modes if
the enum-fallback feature was disabled.

Upgrades to the new GarbageCollection maintenance mode should be fine
even without this change, because it is unlikely that someone can
enable it before older processes stop initiating new backups or S3
refreshes. There is however a risk that a sync job could unmount the
datastore.

Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-api-types/src/datastore.rs | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 7643b0de..8450e69f 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -629,18 +629,22 @@ impl DataStoreConfig {
         }
     }
 
-    pub fn get_maintenance_mode(&self) -> Option<MaintenanceMode> {
-        self.maintenance_mode.as_ref().and_then(|str| {
-            MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new(
-                str,
-                &MaintenanceMode::API_SCHEMA,
-            ))
-            .ok()
-        })
+    pub fn get_maintenance_mode(&self) -> Result<Option<MaintenanceMode>, Error> {
+        self.maintenance_mode
+            .as_ref()
+            .map(|str| {
+                MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new(
+                    str,
+                    &MaintenanceMode::API_SCHEMA,
+                ))
+                .map_err(|e| format_err!("failed to parse maintenance mode: {e}"))
+            })
+            .transpose()
     }
 
     pub fn set_maintenance_mode(&mut self, new_mode: Option<MaintenanceMode>) -> Result<(), Error> {
-        let current_type = self.get_maintenance_mode().map(|mode| mode.ty);
+        // propagate parse errors because they could indicate a new type variant
+        let current_type = self.get_maintenance_mode()?.map(|mode| mode.ty);
         let new_type = new_mode.as_ref().map(|mode| mode.ty);
 
         match current_type {
-- 
2.47.3