public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 3/4] s3: config: update or delete active/passive request limit options
Date: Tue, 30 Jun 2026 16:28:27 +0200	[thread overview]
Message-ID: <20260630142828.660821-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260630142828.660821-1-c.ebner@proxmox.com>

Correctly handle the update/deletion of these limits via the api.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/api2/config/s3.rs | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/src/api2/config/s3.rs b/src/api2/config/s3.rs
index fc0d39e7d..85b5e2557 100644
--- a/src/api2/config/s3.rs
+++ b/src/api2/config/s3.rs
@@ -147,6 +147,10 @@ pub enum DeletableProperty {
     RateOut,
     /// Delete the burst-out property.
     BurstOut,
+    /// Delete the limit-active-requests property.
+    LimitActiveRequests,
+    /// Delete the limit-passive-requests property.
+    LimitPassiveRequests,
     /// Delete the provider quirks property.
     ProviderQuirks,
 }
@@ -230,6 +234,12 @@ pub fn update_s3_client_config(
                 DeletableProperty::BurstOut => {
                     data.config.burst_out = None;
                 }
+                DeletableProperty::LimitActiveRequests => {
+                    data.config.limit_active_requests = None;
+                }
+                DeletableProperty::LimitPassiveRequests => {
+                    data.config.limit_passive_requests = None;
+                }
                 DeletableProperty::ProviderQuirks => {
                     data.config.provider_quirks = None;
                 }
@@ -267,6 +277,12 @@ pub fn update_s3_client_config(
     if let Some(burst_out) = update.burst_out {
         data.config.burst_out = Some(burst_out);
     }
+    if let Some(limit_active_requests) = update.limit_active_requests {
+        data.config.limit_active_requests = Some(limit_active_requests);
+    }
+    if let Some(limit_passive_requests) = update.limit_passive_requests {
+        data.config.limit_passive_requests = Some(limit_passive_requests);
+    }
     if let Some(provider_quirks) = update.provider_quirks {
         data.config.provider_quirks = Some(provider_quirks);
     }
-- 
2.47.3





  parent reply	other threads:[~2026-06-30 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 14:28 [RFC proxmox{,-backup} 0/4] fix #6841: implement request rate limits for all methods Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox 1/4] fix #6841: allow to set active/passive request rate limits Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox 2/4] s3-client: add 429 HTTP status code as retryable Christian Ebner
2026-06-30 14:28 ` Christian Ebner [this message]
2026-06-30 14:28 ` [PATCH proxmox-backup 4/4] ui: expose request rate limit config options for S3 endpoints Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630142828.660821-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal