[PATCH proxmox-backup v2] fix #7187: report: add ethtool output for physical interfaces

[PATCH proxmox-backup v2] fix #7187: report: add ethtool output for physical interfaces

[Erik Fastermann]

Adding ethtool output to the report provides visibility into actual and
supported NIC link speeds, making it much easier to diagnose network
performance issues, negotiation failures, and configuration mismatches.
It also reduces support back-and-forth.

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---

 NOTE: A similar patch was applied to all products:
 pmg, pve, pbs, pdm.

 changes since v1:
 * add a more detailed commit message explaining the rational

 src/server/report.rs | 65 ++++++++++++++++++++++++++++++--------------
 1 file changed, 44 insertions(+), 21 deletions(-)

diff --git a/src/server/report.rs b/src/server/report.rs
index e4c761cdb..46218b79e 100644
--- a/src/server/report.rs
+++ b/src/server/report.rs
@@ -2,6 +2,8 @@ use std::fmt::Write;
 use std::path::Path;
 use std::process::Command;
 
+use proxmox_network_api::NetworkInterfaceType;
+
 fn get_top_processes() -> String {
     let (exe, args) = ("top", vec!["-b", "-c", "-w512", "-n", "1", "-o", "TIME"]);
     let output = Command::new(exe).args(&args).output();
@@ -63,34 +65,55 @@ fn files() -> Vec<(&'static str, Vec<&'static str>)> {
     ]
 }
 
-fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
-    vec![
-        //  ("<command>", vec![<arg [, arg]>])
-        ("date", vec!["-R"]),
-        ("proxmox-backup-manager", vec!["versions", "--verbose"]),
-        ("proxmox-backup-manager", vec!["subscription", "get"]),
-        ("proxmox-backup-manager", vec!["ldap", "list"]),
-        ("proxmox-backup-manager", vec!["openid", "list"]),
-        ("proxmox-boot-tool", vec!["status"]),
-        ("df", vec!["-h"]),
+fn commands() -> Vec<(&'static str, Vec<String>)> {
+    //  ("<command>", vec![<arg [, arg]>])
+    const BASE_COMMANDS: &[(&str, &[&str])] = &[
+        ("date", &["-R"]),
+        ("proxmox-backup-manager", &["versions", "--verbose"]),
+        ("proxmox-backup-manager", &["subscription", "get"]),
+        ("proxmox-backup-manager", &["ldap", "list"]),
+        ("proxmox-backup-manager", &["openid", "list"]),
+        ("proxmox-boot-tool", &["status"]),
+        ("df", &["-h"]),
         (
             "lsblk",
-            vec![
+            &[
                 "--ascii",
                 "-M",
                 "-o",
                 "+HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN",
             ],
         ),
-        ("bash", vec!["-c", "ls -l /dev/disk/by-*/"]),
-        ("zpool", vec!["status"]),
-        ("zfs", vec!["list"]),
-        ("zarcstat", vec![]),
-        ("dmidecode", vec!["-t", "bios"]),
-        ("lscpu", vec![]),
-        ("lspci", vec!["-nnk"]),
-        ("ip", vec!["-details", "-statistics", "a"]),
-    ]
+        ("bash", &["-c", "ls -l /dev/disk/by-*/"]),
+        ("zpool", &["status"]),
+        ("zfs", &["list"]),
+        ("zarcstat", &[]),
+        ("dmidecode", &["-t", "bios"]),
+        ("lscpu", &[]),
+        ("lspci", &["-nnk"]),
+        ("ip", &["-details", "-statistics", "a"]),
+    ];
+
+    let mut commands: Vec<_> = BASE_COMMANDS
+        .into_iter()
+        .map(|(cmd, args)| (*cmd, args.into_iter().map(|arg| arg.to_string()).collect()))
+        .collect();
+
+    match proxmox_network_api::config() {
+        Ok((config, _)) => {
+            let ethtool_commands = config
+                .interfaces
+                .into_iter()
+                .filter(|(_, iface)| iface.interface_type == NetworkInterfaceType::Eth)
+                .map(|(name, _)| ("ethtool", vec![name]));
+            commands.extend(ethtool_commands)
+        }
+        Err(err) => {
+            eprintln!("error while querying network interfaces: {err}")
+        }
+    };
+
+    commands
 }
 
 // (description, function())
@@ -160,7 +183,7 @@ fn get_directory_content(path: impl AsRef<Path>) -> String {
     out
 }
 
-fn get_command_output(exe: &str, args: &Vec<&str>) -> String {
+fn get_command_output(exe: &str, args: &[String]) -> String {
     let output = Command::new(exe)
         .env("PROXMOX_OUTPUT_NO_BORDER", "1")
         .args(args)
-- 
2.47.3