From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: partially-applied: [PATCH datacenter-manager v3 16/16] docs/certificates: use correct certificate file name
Date: Thu, 06 Aug 2026 15:54:19 +0200 [thread overview]
Message-ID: <1786024406.fff3njfixp.astroid@yuna.none> (raw)
In-Reply-To: <20260805155308.519896-18-s.sterz@proxmox.com>
On August 5, 2026 5:53 pm, Shannon Sterz wrote:
> instead of the hard-coded `proxy.pem` that is inaccurate by now.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> docs/certificate-management.rst | 5 +++--
> server/src/auth/certs.rs | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/docs/certificate-management.rst b/docs/certificate-management.rst
> index 9a632118..c85fafef 100644
> --- a/docs/certificate-management.rst
> +++ b/docs/certificate-management.rst
> @@ -320,8 +320,9 @@ logged:
> Apr 04 12:17:51 pdm proxmox-datacenter-manager-daily-update[1170]: Self-signed certificate is valid for an excessive amount of time. Please renew it.
>
> To manually renew a certificate, navigate to Configuration -> Certificates.
> -Select the certificate ``proxy.pem``. Then click the "Delete Custom
> -Certificate" button. Alternatively, you can run the following command:
> +Select the certificate ``/etc/proxmox-datacenter-manager/auth/api.pem``. Then
> +click the "Delete Custom Certificate" button. Alternatively, you can run the
> +following command:
please fold this part into patch #15
>
> .. code-block:: shell
>
> diff --git a/server/src/auth/certs.rs b/server/src/auth/certs.rs
> index 97ee714d..c08ecb6c 100644
> --- a/server/src/auth/certs.rs
> +++ b/server/src/auth/certs.rs
> @@ -57,5 +57,5 @@ pub fn get_certificate_pem() -> Result<Vec<u8>, Error> {
> /// Get the `CertificateInfo` struct for the current certificate.
> pub fn get_certificate_info() -> Result<CertificateInfo, Error> {
> let cert_pem = get_certificate_pem()?;
> - CertificateInfo::from_pem("proxy.pem", &cert_pem)
> + CertificateInfo::from_pem(API_CERT_FN, &cert_pem)
because I applied this hunk here as a standalone commit ;)
prev parent reply other threads:[~2026-08-06 13:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 15:52 [PATCH datacenter-manager/proxmox{,-backup} v3 00/16] TLS Certificate Rotation Shannon Sterz
2026-08-05 15:52 ` [PATCH proxmox v3 01/16] acme-api/tls-certificates: add new crate collecting tls related helpers Shannon Sterz
2026-08-05 15:52 ` [PATCH proxmox v3 02/16] tls-certificates: add days_valid parameter to create_self_signed_cert Shannon Sterz
2026-08-06 13:09 ` Fabian Grünbichler
2026-08-06 13:49 ` Shannon Sterz
2026-08-05 15:52 ` [PATCH proxmox v3 03/16] tls-certificates: add self_signed_cert_expires_in to check certificates Shannon Sterz
2026-08-06 13:09 ` Fabian Grünbichler
2026-08-06 13:49 ` Fabian Grünbichler
2026-08-05 15:52 ` [PATCH proxmox v3 04/16] acme-api: stop re-exporting create_self_signed_cert Shannon Sterz
2026-08-05 15:52 ` [PATCH proxmox-backup v3 05/16] config: use proxmox_tls_certificates for generating self-signed certificates Shannon Sterz
2026-08-06 13:09 ` Fabian Grünbichler
2026-08-06 13:49 ` Shannon Sterz
2026-08-05 15:52 ` [PATCH proxmox-backup v3 06/16] config/server/api: add certificate renewal logic including notifications Shannon Sterz
2026-08-06 13:09 ` Fabian Grünbichler
2026-08-05 15:53 ` [PATCH proxmox-backup v3 07/16] daily update: warn about excessive self-signed certificate lifetime Shannon Sterz
2026-08-05 15:53 ` [PATCH proxmox-backup v3 08/16] docs: document force refreshing long-lived certificates Shannon Sterz
2026-08-05 15:53 ` [PATCH proxmox-backup v3 09/16] backup-manager cli: `cert update` can create auth and csrf key Shannon Sterz
2026-08-06 13:27 ` applied: " Fabian Grünbichler
2026-08-05 15:53 ` [PATCH proxmox-backup v3 10/16] notifications: use `Severity::Error` for acme renewal failures Shannon Sterz
2026-08-06 13:27 ` applied: " Fabian Grünbichler
2026-08-05 15:53 ` [PATCH datacenter-manager v3 11/16] certs: use proxmox-tls-certificates directly, add days_valid parameter Shannon Sterz
2026-08-05 15:53 ` [PATCH datacenter-manager v3 12/16] api/auth/bin: add certificate renewal logic Shannon Sterz
2026-08-05 15:53 ` [PATCH datacenter-manager v3 13/16] cli: expose certificate management endpoints via the cli Shannon Sterz
2026-08-06 13:53 ` applied: " Fabian Grünbichler
2026-08-05 15:53 ` [PATCH datacenter-manager v3 14/16] daily-update: warn about certificates with excessive lifetimes Shannon Sterz
2026-08-05 15:53 ` [PATCH datacenter-manager v3 15/16] docs: add section on forcing a new self-signed certificate Shannon Sterz
2026-08-05 15:53 ` [PATCH datacenter-manager v3 16/16] docs/certificates: use correct certificate file name Shannon Sterz
2026-08-06 13:54 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1786024406.fff3njfixp.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox