public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: applied-series: [RFC proxmox{,-backup} 0/4] fix #6841: implement request rate limits for all methods
Date: Wed, 29 Jul 2026 14:16:46 +0200	[thread overview]
Message-ID: <1785327335.vv0r4zawwj.astroid@yuna.none> (raw)
In-Reply-To: <20260630142828.660821-1-c.ebner@proxmox.com>

On June 30, 2026 4:28 pm, Christian Ebner wrote:
> Currently request performed by the s3 client to the backend can only
> be limited by bandwidth limits or on a per-instance based PUT rate
> limit. Providers might however enforce limits on the number of requests
> per second, non of which can currently be enforced.
> 
> Therefore this patch series implements request limits, using a memory
> mapped shared request limiter, similar to what is used to enforce
> bandwidth limits. Since providers might have different limits as e.g.
> the soft limits by AWS S3 mentioned in [0], allow to set different limits
> between `active` and `passive` requests methods.
> 
> Sending as RFC as a bit unsure if we should make this configurable
> as currently the case or rather trying to dynamically adapt the request
> rate in case of requests failing with the respective HTTP status codes.
> The latter has the downside that different providers may not clearly
> signal when a rate limit is being enforced and/or have different status
> codes to do so. Therefore the current approach allows to hard code the
> limits.
> 
> Currently the rate limit is not yet updated on config changes via API,
> only on s3 client instantiation.
> 
> [1] https://docs.aws.amazon.com/AmazonS3/latest/userguide/optimizing-performance.html
> 
> Reference to the issue in bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=6841
> 
> 
> proxmox:
> 
> Christian Ebner (2):
>   fix #6841: allow to set active/passive request rate limits
>   s3-client: add 429 HTTP status code as retryable
> 
>  proxmox-s3-client/src/api_types.rs |  8 +++-
>  proxmox-s3-client/src/client.rs    | 66 ++++++++++++++++++++++++++----
>  2 files changed, 66 insertions(+), 8 deletions(-)
> 
> 
> proxmox-backup:
> 
> Christian Ebner (2):
>   s3: config: update or delete active/passive request limit options
>   ui: expose request rate limit config options for S3 endpoints
> 
>  src/api2/config/s3.rs      | 16 ++++++++++++++++
>  www/window/S3ClientEdit.js | 14 ++++++++++++++
>  2 files changed, 30 insertions(+)
> 
> 
> Summary over all repositories:
>   4 files changed, 96 insertions(+), 8 deletions(-)
> 
> -- 
> Generated by murpp 0.11.0
> 
> 
> 
> 
> 




      parent reply	other threads:[~2026-07-29 12:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 14:28 [RFC proxmox{,-backup} 0/4] fix #6841: implement request rate limits for all methods Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox 1/4] fix #6841: allow to set active/passive request rate limits Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox 2/4] s3-client: add 429 HTTP status code as retryable Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox-backup 3/4] s3: config: update or delete active/passive request limit options Christian Ebner
2026-06-30 14:28 ` [PATCH proxmox-backup 4/4] ui: expose request rate limit config options for S3 endpoints Christian Ebner
2026-07-29 12:16 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1785327335.vv0r4zawwj.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal