Re: [PATCH proxmox-backup v3 04/10] datastore: restrict chunk store scope to pbs-datastore crate

[Robert Obkircher <r.obkircher@proxmox.com>]

> For better organization of the locking related helpers. This constant
> is used in various places for locking, therefore move it to the more
> fitting central crate lib.
> 
> No functional changes.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/pbs-datastore/src/backup_info.rs b/pbs-datastore/src/backup_info.rs
> index 8abeeb2ea..fbef8e85a 100644
> --- a/pbs-datastore/src/backup_info.rs
> +++ b/pbs-datastore/src/backup_info.rs
> @@ -24,9 +24,8 @@ use crate::datastore::{GROUP_NOTES_FILE_NAME, GROUP_OWNER_FILE_NAME};
>  use crate::manifest::{BackupManifest, MANIFEST_LOCK_NAME};
>  use crate::move_journal;
>  use crate::s3::S3_CONTENT_PREFIX;
> -use crate::{DataBlob, DataStore, DatastoreBackend};
> +use crate::{DATASTORE_LOCKS_DIR, DataBlob, DataStore, DatastoreBackend};
>  
> -pub const DATASTORE_LOCKS_DIR: &str = "/run/proxmox-backup/locks";
>  pub const PROTECTED_MARKER_FILENAME: &str = ".protected";
>  
>  proxmox_schema::const_regex! {
> diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
> index d3faf1214..cfd920dea 100644
> --- a/pbs-datastore/src/chunk_store.rs
> +++ b/pbs-datastore/src/chunk_store.rs
> @@ -18,12 +18,11 @@ use proxmox_sys::process_locker::{
>  };
>  use proxmox_worker_task::WorkerTaskContext;
>  
> -use crate::backup_info::DATASTORE_LOCKS_DIR;
>  use crate::data_blob::DataChunkBuilder;
>  use crate::file_formats::{
>      COMPRESSED_BLOB_MAGIC_1_0, ENCRYPTED_BLOB_MAGIC_1_0, UNCOMPRESSED_BLOB_MAGIC_1_0,
>  };
> -use crate::{DataBlob, LocalDatastoreLruCache};
> +use crate::{DATASTORE_LOCKS_DIR, DataBlob, LocalDatastoreLruCache};
>  
>  const USING_MARKER_FILENAME_EXT: &str = "using";
>  
> diff --git a/pbs-datastore/src/lib.rs b/pbs-datastore/src/lib.rs
> index f522fadf7..0904d7da2 100644
> --- a/pbs-datastore/src/lib.rs
> +++ b/pbs-datastore/src/lib.rs
> @@ -162,6 +162,8 @@ pub const ACTIVE_OPERATIONS_DIR: &str = concat!(
>      pbs_buildcfg::PROXMOX_BACKUP_RUN_DIR_M!(),
>      "/active-operations"
>  );
> +/// Base path for datastore related file locks.
> +pub const DATASTORE_LOCKS_DIR: &str = "/run/proxmox-backup/locks";
I think this could be limited to pub(crate).

-- 
Robert Obkircher <r.obkircher@proxmox.com>