Re: [PATCH proxmox-backup v3 08/10] api/datastore: use maintenance-mode lock to protect against changes

[Robert Obkircher <r.obkircher@proxmox.com>]

> The bucket access check performed when creating a new datastore with
> s3 backend can theoretically block up to the set s3 client request
> timeout of 30 min. It is not acceptable to hold the config lock for
> this long, effectively blocking configuration access for unrelated
> datastores.
> 
> Move the check to the start so it is performed before even locking
> the config.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> index b3b6ed8c6..bbbd79ab0 100644
> --- a/src/api2/config/datastore.rs
> +++ b/src/api2/config/datastore.rs
> @@ -166,6 +166,13 @@ pub fn create_datastore(
>      overwrite_in_use: bool,
>      rpcenv: &mut dyn RpcEnvironment,
>  ) -> Result<String, Error> {
> +    let (backend, s3_client) = DataStore::s3_client_and_backend_from_datastore_config(&config)?;
> +    if let Some(s3_client) = s3_client {
> +        proxmox_async::runtime::block_on(s3_client.head_bucket())
> +            .context("failed to access bucket")
> +            .map_err(|err| format_err!("{err:#}"))?;
> +    }
> +
This could now incremnt the request counters of an existing store,
but that shold be ok and I didn't spot any other side effects.

-- 
Robert Obkircher <r.obkircher@proxmox.com>