public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-backup] removable device attach service: improve description
@ 2026-04-29 14:01 Fiona Ebner
  2026-04-29 16:23 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2026-04-29 14:01 UTC (permalink / raw)
  To: pbs-devel

The previous wording might suggest that mount is attempted for all
devices or that all devices belong to a datastore.

Reported-by: Stefan Hanreich <s.hanreich@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Before:
> Started removable-device-attach@19e31ef7-975e-4d1e-aff3-2f4f678630bc.service -
> Try to mount the removable device of a datastore with uuid '19e31ef7-975e-4d1e-aff3-2f4f678630bc'..

After:
> Started removable-device-attach@0f19ad6b-4c61-432e-9c61-b2d7c6eb24d1.service -
> Conditionally mounting device with uuid '0f19ad6b-4c61-432e-9c61-b2d7c6eb24d1' if it belongs to a removable datastore..

 etc/removable-device-attach@.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/removable-device-attach@.service b/etc/removable-device-attach@.service
index e10d1ea3c..11196eb8f 100644
--- a/etc/removable-device-attach@.service
+++ b/etc/removable-device-attach@.service
@@ -1,5 +1,5 @@
 [Unit]
-Description=Try to mount the removable device of a datastore with uuid '%i'.
+Description=Conditionally mounting device with uuid '%i' if it belongs to a removable datastore
 After=proxmox-backup-proxy.service
 Requires=proxmox-backup-proxy.service
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH proxmox-backup] removable device attach service: improve description
  2026-04-29 14:01 [PATCH proxmox-backup] removable device attach service: improve description Fiona Ebner
@ 2026-04-29 16:23 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-04-29 16:23 UTC (permalink / raw)
  To: pbs-devel, Fiona Ebner

On Wed, 29 Apr 2026 16:01:46 +0200, Fiona Ebner wrote:
> The previous wording might suggest that mount is attempted for all
> devices or that all devices belong to a datastore.

Applied, thanks!

[1/1] removable device attach service: improve description
      commit: c02a2deeed17429696aa41be3e126020c0839853




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-29 16:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 14:01 [PATCH proxmox-backup] removable device attach service: improve description Fiona Ebner
2026-04-29 16:23 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal