* [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts
@ 2026-04-29 10:11 Arthur Bied-Charreton
2026-04-29 16:23 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Arthur Bied-Charreton @ 2026-04-29 10:11 UTC (permalink / raw)
To: pbs-devel
The errors returned by the encryption-keys and tape-encryption-keys
endpoints are not plain strings, so the alerts displayed on API2 errors
like failed permission checks end up being empty and therefore not very
helpful.
Extract the error messages to display them correctly in alerts.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
Sorry forgot to fold the htmlStatus change into the commit..
www/config/EncryptionKeysView.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js
index 0f9367c7..db2fd641 100644
--- a/www/config/EncryptionKeysView.js
+++ b/www/config/EncryptionKeysView.js
@@ -168,7 +168,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
});
}
} catch (error) {
- Ext.Msg.alert(gettext('Error'), error);
+ Ext.Msg.alert(gettext('Error'), error.htmlStatus || gettext('Unknown error'));
}
try {
@@ -181,7 +181,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
});
}
} catch (error) {
- Ext.Msg.alert(gettext('Error'), error);
+ Ext.Msg.alert(gettext('Error'), error.htmlStatus || gettext('Unknown error'));
}
let store = view.getStore().rstore;
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts
2026-04-29 10:11 [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts Arthur Bied-Charreton
@ 2026-04-29 16:23 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-04-29 16:23 UTC (permalink / raw)
To: pbs-devel, Arthur Bied-Charreton
On Wed, 29 Apr 2026 12:11:06 +0200, Arthur Bied-Charreton wrote:
> The errors returned by the encryption-keys and tape-encryption-keys
> endpoints are not plain strings, so the alerts displayed on API2 errors
> like failed permission checks end up being empty and therefore not very
> helpful.
>
> Extract the error messages to display them correctly in alerts.
>
> [...]
Applied, thanks!
[1/1] ui: encryption keys: show error text instead of empty popup in API alerts
commit: e685a30c3e2c071116b21d43e13726f9cd1a8d5d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-29 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 10:11 [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts Arthur Bied-Charreton
2026-04-29 16:23 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox