From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com,
"Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] proxmox-product-config: fix code documentation on permissions
Date: Tue, 5 Aug 2025 18:43:08 +0200 [thread overview]
Message-ID: <175441218714.3241235.14680310819144561103.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250507153639.46774-1-l.leahu-vladucu@proxmox.com>
On Wed, 07 May 2025 17:36:39 +0200, Laurențiu Leahu-Vlăducu wrote:
> This patch fixes the documentation of some functions being
> inconsistent with the actual code. While such inconsistencies are
> never good, when it comes to permissions, they might have even worse
> consequences.
>
> To be precise, this patch fixes the following:
> - replace_config() actually uses permissions 0640 (docs stated 0660)
> - although the possibility of setting a privileged user (usually root,
> but possibly different) has been added in the past, the docs still
> stated "root" or "superuser". However, some functions also explicitly
> use "root", which made it even more confusing. It is now clear which
> functions use the API user, which use the privileged user, and which
> explicitly use root.
> - fixed some small style inconsistencies (e.g. priv-user instead
> of priv_user)
>
> [...]
Applied, thanks!
[1/1] proxmox-product-config: fix code documentation on permissions
commit: 0dcc45957c8df30ffc37ef2f5b3974d74b535ba7
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-05 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 15:36 [pbs-devel] [PATCH proxmox] proxmox-product-config: fix code documentation on permissions Laurențiu Leahu-Vlăducu
2025-08-05 16:43 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175441218714.3241235.14680310819144561103.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.leahu-vladucu@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox