From: Christian Ebner <c.ebner@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: Re: [RFC common/proxmox{,-backup}/storage 0/7] establish unique instance-id for PBS nodes
Date: Tue, 14 Apr 2026 16:45:44 +0200 [thread overview]
Message-ID: <0e7915b6-a695-4c7c-8ee4-61f73ad119f8@proxmox.com> (raw)
In-Reply-To: <20260413121057.371772-1-l.wagner@proxmox.com>
On 4/13/26 2:10 PM, Lukas Wagner wrote:
> In PDM we require some way to match PBS storage <-> PBS remote.
>
> Having some kind of unique ID for each PBS instance should make it quite easy
> to establish such a mapping completely automatically.
>
> The general approach would be
> 1.) add /nodes/localhost/instance-id route in PBS, returning a unique, per-installation ID
> 2.) add something like /nodes/.../storage/<id>/instance-id in PVE, which uses
> proxmox-backup-client internally to return the instance ID for this PBS storage
> 3.) PDM can then use both API routes to establish the mapping
Approach and implementation details are okay, only left a few comments
mostly with respect to client side naming, as this could cause confusion
IMO.
For the PVE api endpoint, maybe use `backend-id` or the like, to signal
that this is not an unique id of the storage instance, but whatever is
backing it? But not to sure either here.
prev parent reply other threads:[~2026-04-14 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 12:10 Lukas Wagner
2026-04-13 12:10 ` [PATCH proxmox 1/7] pbs-api-types: add InstanceId response type Lukas Wagner
2026-04-13 12:10 ` [PATCH proxmox 2/7] systemd: add support for machine-id generation Lukas Wagner
2026-04-13 12:10 ` [PATCH proxmox-backup 3/7] api: add /nodes/localhost/instance-id Lukas Wagner
2026-04-14 14:23 ` Christian Ebner
2026-04-15 9:21 ` Lukas Wagner
2026-04-15 9:26 ` Christian Ebner
2026-04-13 12:10 ` [PATCH proxmox-backup 4/7] client: add 'instance-id' sub-command Lukas Wagner
2026-04-13 13:26 ` Shannon Sterz
2026-04-13 13:39 ` Lukas Wagner
2026-04-14 14:30 ` Christian Ebner
2026-04-13 12:10 ` [PATCH proxmox-backup 5/7] manager: add instance-id subcommand Lukas Wagner
2026-04-13 13:26 ` Shannon Sterz
2026-04-13 13:38 ` Lukas Wagner
2026-04-13 12:10 ` [PATCH common 6/7] pbs-client: add support for the 'instance id' command Lukas Wagner
2026-04-13 12:10 ` [PATCH pve-storage 7/7] api: add /nodes/<node>/storage/<storage>/instance-id route Lukas Wagner
2026-04-13 13:26 ` Shannon Sterz
2026-04-13 13:37 ` Lukas Wagner
2026-04-14 14:38 ` Christian Ebner
2026-04-15 8:41 ` Lukas Wagner
2026-04-15 8:44 ` Christian Ebner
2026-04-14 14:45 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e7915b6-a695-4c7c-8ee4-61f73ad119f8@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox