From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8BC921FF137 for ; Tue, 14 Apr 2026 16:45:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CADB91C5FC; Tue, 14 Apr 2026 16:46:19 +0200 (CEST) Message-ID: <0e7915b6-a695-4c7c-8ee4-61f73ad119f8@proxmox.com> Date: Tue, 14 Apr 2026 16:45:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC common/proxmox{,-backup}/storage 0/7] establish unique instance-id for PBS nodes To: Lukas Wagner , pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com References: <20260413121057.371772-1-l.wagner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260413121057.371772-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776177869329 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LZTPBZVCCJDEGHP4KIJWHKNELB5CZMUZ X-Message-ID-Hash: LZTPBZVCCJDEGHP4KIJWHKNELB5CZMUZ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/13/26 2:10 PM, Lukas Wagner wrote: > In PDM we require some way to match PBS storage <-> PBS remote. > > Having some kind of unique ID for each PBS instance should make it quite easy > to establish such a mapping completely automatically. > > The general approach would be > 1.) add /nodes/localhost/instance-id route in PBS, returning a unique, per-installation ID > 2.) add something like /nodes/.../storage//instance-id in PVE, which uses > proxmox-backup-client internally to return the instance ID for this PBS storage > 3.) PDM can then use both API routes to establish the mapping Approach and implementation details are okay, only left a few comments mostly with respect to client side naming, as this could cause confusion IMO. For the PVE api endpoint, maybe use `backend-id` or the like, to signal that this is not an unique id of the storage instance, but whatever is backing it? But not to sure either here.