all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Nicolas Frey <n.frey@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs
Date: Wed, 16 Sep 2026 12:21:33 +0200	[thread overview]
Message-ID: <s8oqzitqyxe.fsf@toolbox> (raw)
In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com> (Nicolas Frey's message of "Tue, 15 Sep 2026 16:32:34 +0200")

Nicolas Frey <n.frey@proxmox.com> writes:


> This series fixes #7801 by implementing backend-only checks for VirtIO
> ISOs with known issues. When a user starts, creates, or updates a VM,
> the system scans for problematic VirtIO filenames and logs a warning in
> the task log if a known issue is detected.
>
> This approach supersedes the earlier UI patches [0], following feedback
> to implement the check in the backend. Since the backend check already
> alerts users via task log warnings (an equally effective and less intrusive
> solution) the separate API call and UI patches became unnecessary.
>
> Thanks Dominik and Maximilano for the feedback on the last revision
>
> [0] https://lore.proxmox.com/all/20260826074935.78437-1-n.frey@proxmox.com/

Tested:

- qm set 104 --ide0 local:iso/virtio-win-0.1.285.iso,media=cdrom
- qm set 104 --ide1 local:iso/virtio-win-0.1.262.iso,media=cdrom
- qm start 104

the CLI produces 2 warnings as described in the commits.

Note that the setting the ISOs in the UI won't produce a warnings and
since there is no task, there will not be any visible issue. However,
having warnings on qmstart is good enough in my opinion.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano




  parent reply	other threads:[~2026-09-16 10:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 14:32 [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs Nicolas Frey
2026-09-15 14:32 ` [PATCH qemu-server 1/3] drive: add helper to detect VirtIO driver ISOs with known issues Nicolas Frey
2026-09-16 10:16   ` Maximiliano Sandoval
2026-09-16 10:23   ` Maximiliano Sandoval
2026-09-15 14:32 ` [PATCH qemu-server 2/3] partially fix #7801: api: warn about problematic VirtIO driver ISOs Nicolas Frey
2026-09-15 14:32 ` [PATCH qemu-server 3/3] partially fix #7801: vm start: warn about problematic VirtIO ISOs Nicolas Frey
2026-09-16 10:21 ` Maximiliano Sandoval [this message]
2026-09-16 10:26   ` [PATCH qemu-server 0/3] fix #7801: " Maximiliano Sandoval
2026-09-17 13:17 ` Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8oqzitqyxe.fsf@toolbox \
    --to=m.sandoval@proxmox.com \
    --cc=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal