[PATCH qemu-server 2/3] partially fix #7801: api: warn about problematic VirtIO driver ISOs

[Nicolas Frey <n.frey@proxmox.com>]

Warn when a CD-ROM drive of a Windows guest gets a VirtIO driver ISO
with known issues assigned on update and create.

The OS type can be set in the same request as the drive, so prefer a
newly requested one over the one from the configuration.

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 src/PVE/API2/Qemu.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 71247eec..b2860a49 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -1511,6 +1511,8 @@ __PACKAGE__->register_method({
                     my $vga = PVE::QemuServer::parse_vga($conf->{vga});
                     PVE::QemuServer::assert_clipboard_config($vga);
 
+                    PVE::QemuServer::Drive::warn_about_virtio_win_issues_in_config($conf);
+
                     # auto generate uuid if user did not specify smbios1 option
                     if (!$conf->{smbios1}) {
                         $conf->{smbios1} = PVE::QemuServer::generate_smbios1_uuid();
@@ -2411,6 +2413,15 @@ my $update_vm_api = sub {
 
                 # new drive
                 $check_drive_perms->($opt, $param->{$opt});
+
+                # warn about virtio win known issues only on windows
+                my $ostype = $param->{ostype} // $conf->{pending}->{ostype} // $conf->{ostype};
+                if (PVE::QemuServer::Helpers::windows_version($ostype)) {
+                    my $drive = PVE::QemuServer::parse_drive($opt, $param->{$opt}, 1);
+                    PVE::QemuServer::Drive::warn_about_virtio_win_issues($opt, $drive->{file})
+                        if $drive && PVE::QemuServer::drive_is_cdrom($drive, 1);
+                }
+
                 PVE::QemuServer::vmconfig_register_unused_drive(
                     $storecfg,
                     $vmid,
-- 
2.47.3