From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 811A61FF0AE for ; Tue, 15 Sep 2026 16:33:05 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5584121611; Tue, 15 Sep 2026 16:32:45 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/3] partially fix #7801: api: warn about problematic VirtIO driver ISOs Date: Tue, 15 Sep 2026 16:32:36 +0200 Message-ID: <20260915143237.1033142-3-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com> References: <20260915143237.1033142-1-n.frey@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.933 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: ZICMAJNIEVYCCH6AC47NL3NM4IIQABZF X-Message-ID-Hash: ZICMAJNIEVYCCH6AC47NL3NM4IIQABZF X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Warn when a CD-ROM drive of a Windows guest gets a VirtIO driver ISO with known issues assigned on update and create. The OS type can be set in the same request as the drive, so prefer a newly requested one over the one from the configuration. Signed-off-by: Nicolas Frey --- src/PVE/API2/Qemu.pm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 71247eec..b2860a49 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -1511,6 +1511,8 @@ __PACKAGE__->register_method({ my $vga = PVE::QemuServer::parse_vga($conf->{vga}); PVE::QemuServer::assert_clipboard_config($vga); + PVE::QemuServer::Drive::warn_about_virtio_win_issues_in_config($conf); + # auto generate uuid if user did not specify smbios1 option if (!$conf->{smbios1}) { $conf->{smbios1} = PVE::QemuServer::generate_smbios1_uuid(); @@ -2411,6 +2413,15 @@ my $update_vm_api = sub { # new drive $check_drive_perms->($opt, $param->{$opt}); + + # warn about virtio win known issues only on windows + my $ostype = $param->{ostype} // $conf->{pending}->{ostype} // $conf->{ostype}; + if (PVE::QemuServer::Helpers::windows_version($ostype)) { + my $drive = PVE::QemuServer::parse_drive($opt, $param->{$opt}, 1); + PVE::QemuServer::Drive::warn_about_virtio_win_issues($opt, $drive->{file}) + if $drive && PVE::QemuServer::drive_is_cdrom($drive, 1); + } + PVE::QemuServer::vmconfig_register_unused_drive( $storecfg, $vmid, -- 2.47.3