Re: [PATCH qemu-server 1/3] drive: add helper to detect VirtIO driver ISOs with known issues

[Fiona Ebner <f.ebner@proxmox.com>]

Am 16.09.26 um 12:23 PM schrieb Maximiliano Sandoval:
> Nicolas Frey <n.frey@proxmox.com> writes:
>> +}
>> +
>> +# warn about every CD-ROM drive in $conf that contains a problematic VirtIO driver ISO
>> +sub warn_about_virtio_win_issues_in_config {
>> +    my ($conf) = @_;
>> +
>> +    return if !PVE::QemuServer::Helpers::windows_version($conf->{ostype});
>> +
>> +    for my $opt (valid_drive_names()) {
>> +        next if !defined($conf->{$opt});
>> +
>> +        my $drive = eval { parse_drive($opt, $conf->{$opt}) };
>> +        next if !$drive || !drive_is_cdrom($drive, 1);
>> +
>> +        warn_about_virtio_win_issues($opt, $drive->{file});
>> +    }
>> +
>> +    return;
> 
> cosmetic nit: This return might be redundant.
> 

IMHO, having such explicit 'return' statements is nice to see the
intention clearly. Perl will return the result of the last expression
implicitly, which can actually lead to accidents in practice:
https://lore.proxmox.com/pve-devel/20240226141020.296052-2-t.lamprecht@proxmox.com/

>> +}
>> +
>>  sub parse_drive_interface {
>>      my ($key) = @_;
>