[PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval]

The schema at qemu-server does not limit the socket amount.

As per our NUMA documentation [1]:

> If the NUMA option is used, it is recommended to set the number of sockets to
> the number of nodes of the host system.

Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
Xeon Platinum 8160 and EPYC 73F3.

[1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    Differences from v2:
    - Remove the maxValue setting
    
    Differences from v1:
    - Set the maxValue to 8

 www/manager6/qemu/ProcessorEdit.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
index 719f771a7..f640de421 100644
--- a/www/manager6/qemu/ProcessorEdit.js
+++ b/www/manager6/qemu/ProcessorEdit.js
@@ -129,7 +129,6 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
             xtype: 'proxmoxintegerfield',
             name: 'sockets',
             minValue: 1,
-            maxValue: 4,
             value: '1',
             fieldLabel: gettext('Sockets'),
             allowBlank: false,
-- 
2.47.3

Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> The schema at qemu-server does not limit the socket amount.
>
> As per our NUMA documentation [1]:
>
>> If the NUMA option is used, it is recommended to set the number of sockets to
>> the number of nodes of the host system.
>
> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
> Xeon Platinum 8160 and EPYC 73F3.
>
> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

The commit title should be " ui: processor edit: allow setting 4 sockets".

-- 
Maximiliano

Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[Dominik Csapak]

On 7/10/26 10:45 AM, Maximiliano Sandoval wrote:
> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> 
>> The schema at qemu-server does not limit the socket amount.
>>
>> As per our NUMA documentation [1]:
>>
>>> If the NUMA option is used, it is recommended to set the number of sockets to
>>> the number of nodes of the host system.
>>
>> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
>> Xeon Platinum 8160 and EPYC 73F3.
>>
>> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> 
> The commit title should be " ui: processor edit: allow setting 4 sockets".
> 

IMO both titles don't make sense, since 4 is already allowed before the
patch and yes 8 is allowed afterwards but so is 16,32,etc.


and we don't have to argument with numa in the commit message
e.g. it could be enought explain it like this:

suggestion:

ui: processor: edit: remove UI limit on socket count

The backend imposes no limit on the number of sockets, so the UI
should not either. Remove the arbitrary cap and let users set
socket counts as high as the backend allows.

Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval]

Dominik Csapak <d.csapak@proxmox.com> writes:

> On 7/10/26 10:45 AM, Maximiliano Sandoval wrote:
>> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>> 
>>> The schema at qemu-server does not limit the socket amount.
>>>
>>> As per our NUMA documentation [1]:
>>>
>>>> If the NUMA option is used, it is recommended to set the number of sockets to
>>>> the number of nodes of the host system.
>>>
>>> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
>>> Xeon Platinum 8160 and EPYC 73F3.
>>>
>>> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>>>
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> The commit title should be " ui: processor edit: allow setting 4 sockets".
>> 
>
> IMO both titles don't make sense, since 4 is already allowed before the
> patch and yes 8 is allowed afterwards but so is 16,32,etc.

Sorry my brain got mangled between emails, i tough the title was "more
than 4".

> and we don't have to argument with numa in the commit message
> e.g. it could be enought explain it like this:
>
> suggestion:
>
> ui: processor: edit: remove UI limit on socket count
>
> The backend imposes no limit on the number of sockets, so the UI
> should not either. Remove the arbitrary cap and let users set
> socket counts as high as the backend allows.

Will send new version.

-- 
Maximiliano