Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Dominik Csapak <d.csapak@proxmox.com> writes:

> On 7/10/26 10:45 AM, Maximiliano Sandoval wrote:
>> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>> 
>>> The schema at qemu-server does not limit the socket amount.
>>>
>>> As per our NUMA documentation [1]:
>>>
>>>> If the NUMA option is used, it is recommended to set the number of sockets to
>>>> the number of nodes of the host system.
>>>
>>> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
>>> Xeon Platinum 8160 and EPYC 73F3.
>>>
>>> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>>>
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> The commit title should be " ui: processor edit: allow setting 4 sockets".
>> 
>
> IMO both titles don't make sense, since 4 is already allowed before the
> patch and yes 8 is allowed afterwards but so is 16,32,etc.

Sorry my brain got mangled between emails, i tough the title was "more
than 4".

> and we don't have to argument with numa in the commit message
> e.g. it could be enought explain it like this:
>
> suggestion:
>
> ui: processor: edit: remove UI limit on socket count
>
> The backend imposes no limit on the number of sockets, so the UI
> should not either. Remove the arbitrary cap and let users set
> socket counts as high as the backend allows.

Will send new version.

-- 
Maximiliano