From: Gabriel Goller <g.goller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support
Date: Wed, 20 May 2026 15:02:41 +0200 [thread overview]
Message-ID: <pp4jz7uhdrqujv67q6crfwhind2uycldhr6z7rlx77rqqqjznb@fjr7jexrnw2x> (raw)
In-Reply-To: <2c64560f-5926-4598-a13f-b9a990537491@proxmox.com>
On 20.05.2026 14:57, Dominik Csapak wrote:
> because i just looked at this while trying to make a similar change:
>
> is the reverse not also possible? so ipv6-only fabrics?
not currently. We'll have to see how we implement ospfv3 (ospf with ipv6
support) in the future (if that is a separate ipv6-only fabric or integrate into
the existing ospf).
> i noticed that when i add a fabric i have to enter *either* a
> ipv4 or ipv6 address, but the subsequent node edit windows always
> show both (even thouh i didn't configure an ipv4 address)
>
> not sure if that makes sense?
Yeah, that's a bit weird. Don't know if we can easily fix this and hide the
other input if the fabrics prefix of that address family is empty?
> On 5/20/26 2:51 PM, Gabriel Goller wrote:
> > For fabricrs that only support IPv4, the IPv4 prefix is the only
> > available prefix field. Mark it as mandatory in that case while keeping
> > it optional for fabric types that also support IPv6.
> >
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> > www/manager6/sdn/fabrics/FabricEdit.js | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
> > index 1f7bab362075..760925c50b95 100644
> > --- a/www/manager6/sdn/fabrics/FabricEdit.js
> > +++ b/www/manager6/sdn/fabrics/FabricEdit.js
> > @@ -60,7 +60,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
> > fieldLabel: gettext('IPv4 Prefix'),
> > labelWidth: 120,
> > name: 'ip_prefix',
> > - allowBlank: true,
> > + allowBlank: me.hasIpv6Support,
> > skipEmptyText: true,
> > deleteEmpty: '{!isCreate}',
> > });
>
next prev parent reply other threads:[~2026-05-20 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 12:51 [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support Gabriel Goller
2026-05-20 12:57 ` Dominik Csapak
2026-05-20 13:02 ` Gabriel Goller [this message]
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: validate prefixes as CIDR addresses Gabriel Goller
2026-05-20 13:35 ` [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Thomas Lamprecht
2026-05-20 13:43 ` Gabriel Goller
2026-05-20 14:00 ` Thomas Lamprecht
2026-05-20 14:05 ` Thomas Lamprecht
2026-05-20 14:20 ` Gabriel Goller
2026-05-20 14:14 ` applied: " Thomas Lamprecht
2026-05-20 14:23 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pp4jz7uhdrqujv67q6crfwhind2uycldhr6z7rlx77rqqqjznb@fjr7jexrnw2x \
--to=g.goller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.