Re: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 20.05.26 um 14:51 schrieb Gabriel Goller:
> The prefix fields used an invalid cbind setup for their disabled state,
> so the bindings didn't work and editing the fabric prefix was possible.
> 
> Initially we didn't want the user to be able to update the prefix of a
> fabric, because we would need to add a mechanism to update all the node
> ips at the same time. This broke though and they became editable --
> which is fine, since you still get an error "node has ip out of prefix".
> Keep it this way, because editing a fabric without nodes is still
> useful.
> 
> Remove the dead disabled bindings while keeping deleteEmpty handling.
> 
> Fixes: e5e3374273af ("ui: fabrics: edit: make ipv4/6 support generic over fabric panels")
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  www/manager6/sdn/fabrics/FabricEdit.js | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
> index 46c8dd6b0c86..1f7bab362075 100644
> --- a/www/manager6/sdn/fabrics/FabricEdit.js
> +++ b/www/manager6/sdn/fabrics/FabricEdit.js
> @@ -62,10 +62,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>                  name: 'ip_prefix',
>                  allowBlank: true,
>                  skipEmptyText: true,
> -                cbind: {
> -                    disabled: '{!isCreate}',
> -                    deleteEmpty: '{!isCreate}',
> -                },
> +                deleteEmpty: '{!isCreate}',

using that template syntax only makes sense inside a bind (viewModel) or
cbind (config bind), but you move them out of there, so this is not basically
a literal string. Should be rather changed to a literal true or false or
just dropped

>              });
>          }
>  
> @@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>                      name: 'ip6_prefix',
>                      allowBlank: true,
>                      skipEmptyText: true,
> -                    cbind: {
> -                        disabled: '{!isCreate}',
> -                        deleteEmpty: '{!isCreate}',
> -                    },
> +                    deleteEmpty: '{!isCreate}',

same here

>                      listeners: {
>                          change: function (textbox, value) {
>                              let vm = textbox.up('window').getViewModel();