all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings
Date: Wed, 20 May 2026 14:51:16 +0200	[thread overview]
Message-ID: <20260520125125.251655-1-g.goller@proxmox.com> (raw)

The prefix fields used an invalid cbind setup for their disabled state,
so the bindings didn't work and editing the fabric prefix was possible.

Initially we didn't want the user to be able to update the prefix of a
fabric, because we would need to add a mechanism to update all the node
ips at the same time. This broke though and they became editable --
which is fine, since you still get an error "node has ip out of prefix".
Keep it this way, because editing a fabric without nodes is still
useful.

Remove the dead disabled bindings while keeping deleteEmpty handling.

Fixes: e5e3374273af ("ui: fabrics: edit: make ipv4/6 support generic over fabric panels")
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/manager6/sdn/fabrics/FabricEdit.js | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 46c8dd6b0c86..1f7bab362075 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -62,10 +62,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
                 name: 'ip_prefix',
                 allowBlank: true,
                 skipEmptyText: true,
-                cbind: {
-                    disabled: '{!isCreate}',
-                    deleteEmpty: '{!isCreate}',
-                },
+                deleteEmpty: '{!isCreate}',
             });
         }
 
@@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
                     name: 'ip6_prefix',
                     allowBlank: true,
                     skipEmptyText: true,
-                    cbind: {
-                        disabled: '{!isCreate}',
-                        deleteEmpty: '{!isCreate}',
-                    },
+                    deleteEmpty: '{!isCreate}',
                     listeners: {
                         change: function (textbox, value) {
                             let vm = textbox.up('window').getViewModel();
-- 
2.47.3





             reply	other threads:[~2026-05-20 12:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:51 Gabriel Goller [this message]
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support Gabriel Goller
2026-05-20 12:57   ` Dominik Csapak
2026-05-20 13:02     ` Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: validate prefixes as CIDR addresses Gabriel Goller
2026-05-20 13:35 ` [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Thomas Lamprecht
2026-05-20 13:43   ` Gabriel Goller
2026-05-20 14:00 ` Thomas Lamprecht
2026-05-20 14:05   ` Thomas Lamprecht
2026-05-20 14:20     ` Gabriel Goller
2026-05-20 14:14 ` applied: " Thomas Lamprecht
2026-05-20 14:23   ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520125125.251655-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal