all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output
Date: Fri, 28 Aug 2026 17:54:10 +0200	[thread overview]
Message-ID: <fba4fce5-9163-4bf9-9940-21d6be0db658@proxmox.com> (raw)
In-Reply-To: <a2c3b38c-e5b7-4656-91bc-cf309c5fbf02@proxmox.com>

On 8/28/26 09:10, Christian Ebner wrote:
> -snip-
>
> Thanks for the patch! Did you also check the task filter 
> implementations in PVE/PDM?
>
> At least for PDM there is some analogous logic [0] which at first 
> glance requires adaption as well. Note that there it is shared for PVE 
> and PBS.
>
> [0] 
> https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=server/src/remote_tasks/mod.rs;h=5fba867dfc675970ebc5037165f49efee439f545;hb=HEAD#l143
I've now checked the behavior on all four platforms.
For PVE the tasks endpoint is just run against finished tasls [1] and
only returns tasks with errors as intended.
For PDM there are two patches [2], one for the PDM internal tasks
API since it has the same problem as the PBS API.
The additional one aligns the fetched tasks from PVE to the ones
from PBS and PDM alike since the linked filter logic in [0] already
works for these types of running tasks.
PMG also does not return running tasks, so nothing to do.

[1] 
https://git.proxmox.com/?p=pve-manager.git;a=blob;f=PVE/API2/Tasks.pm;h=df39dc77c2c0bbd917431be4881d654a50b72a21;hb=HEAD#l39
[2] 
https://lore.proxmox.com/pdm-devel/20260828155110.563237-1-j.theisen@proxmox.com/T/#t 





      reply	other threads:[~2026-08-28 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 15:47 [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output Jonas Theisen
2026-08-28  6:31 ` Maximiliano Sandoval
2026-08-28  7:09 ` Christian Ebner
2026-08-28 15:54   ` Jonas Theisen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fba4fce5-9163-4bf9-9940-21d6be0db658@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal