From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 6DE411FF0DF for ; Fri, 28 Aug 2026 17:54:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3761821541; Fri, 28 Aug 2026 17:54:20 +0200 (CEST) Message-ID: Date: Fri, 28 Aug 2026 17:54:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output To: pbs-devel@lists.proxmox.com References: <20260827154740.427154-1-j.theisen@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787932441027 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.871 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5R2GNK6RVEZDRC2FWEUVDBMPFPP67DGV X-Message-ID-Hash: 5R2GNK6RVEZDRC2FWEUVDBMPFPP67DGV X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/28/26 09:10, Christian Ebner wrote: > -snip- > > Thanks for the patch! Did you also check the task filter > implementations in PVE/PDM? > > At least for PDM there is some analogous logic [0] which at first > glance requires adaption as well. Note that there it is shared for PVE > and PBS. > > [0] > https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=server/src/remote_tasks/mod.rs;h=5fba867dfc675970ebc5037165f49efee439f545;hb=HEAD#l143 I've now checked the behavior on all four platforms. For PVE the tasks endpoint is just run against finished tasls [1] and only returns tasks with errors as intended. For PDM there are two patches [2], one for the PDM internal tasks API since it has the same problem as the PBS API. The additional one aligns the fetched tasks from PVE to the ones from PBS and PDM alike since the linked filter logic in [0] already works for these types of running tasks. PMG also does not return running tasks, so nothing to do. [1] https://git.proxmox.com/?p=pve-manager.git;a=blob;f=PVE/API2/Tasks.pm;h=df39dc77c2c0bbd917431be4881d654a50b72a21;hb=HEAD#l39 [2] https://lore.proxmox.com/pdm-devel/20260828155110.563237-1-j.theisen@proxmox.com/T/#t