Re: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Jonas Theisen <j.theisen@proxmox.com> writes:

> Currently running tasks are returned by the PBS API in the query
> for errored tasks.
> This patch adds an additional condition to filter out running tasks
> when queried for errored tasks.
>
> Reported in https://forum.proxmox.com/threads/163872/,
> https://forum.proxmox.com/threads/185999/ and
> https://bugzilla.proxmox.com/show_bug.cgi?id=6251
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>  src/api2/node/tasks.rs | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/api2/node/tasks.rs b/src/api2/node/tasks.rs
> index 96f5e080f..4786820a3 100644
> --- a/src/api2/node/tasks.rs
> +++ b/src/api2/node/tasks.rs
> @@ -610,6 +610,7 @@ pub fn list_tasks(
>              (Some(state), Some(filters)) if !filters.contains(&tasktype(state)) => {
>                  continue;
>              }
> +            (None, _) if errors => continue,
>              (None, Some(_)) => continue,
>              _ => {}
>          }

What I tested:

>From one terminal:

    proxmox-backup-manager garbage-collection start <datastore>

before the task finished, from another terminal:

    proxmox-backup-debug api get /nodes/$(hostname)/tasks --limit 3 --errors true

Without this patch, the GC task would show in the task list even though
it does not have errors. This is addressed by the patch.

lgtm.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano