Re: [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component

[Dominik Csapak <d.csapak@proxmox.com>]

Thanks for the patches,

i wrote some comments on the individual patches

On 10/28/26 4:15 PM, Nicolas Frey wrote:
> as it's already been used in internal GUI, put it into the yew
> widget toolkit for potential future use in our products.
> 
> first patch is something independent that I noticed while looking
> through the data table code. the following two pathces fix existing issues
> regarding multi select in a datatable, namely to do with how selection
> behaves in combination with filtering.
> 
> this multi-select implementation addresses the issue the doc comment
> for the Combobox mentions, by listing the selected values in a comma
> separated list and breaking at the form input's width.
> 
> proxmox-yew-widget-toolkit:
> 
> Nicolas Frey (5):
>    widget: data table: simplify lookup of keys near the cursor
>    widget: data table: only extend explicit select all to new rows
>    widget: grid picker: keep selected records hidden by the filter
>    widget: form: implement multi select field
>    widget: form: combobox: update doc to point to `MultiSelect`
> 
>   src/state/data_store.rs             |   3 +
>   src/state/store.rs                  |   4 +
>   src/state/tree_store/mod.rs         |   4 +
>   src/widget/data_table/data_table.rs |  89 +++++---
>   src/widget/form/combobox.rs         |   5 +-
>   src/widget/form/mod.rs              |   5 +
>   src/widget/form/multi_select.rs     | 308 ++++++++++++++++++++++++++++
>   src/widget/grid_picker.rs           |   2 +
>   8 files changed, 391 insertions(+), 29 deletions(-)
>   create mode 100644 src/widget/form/multi_select.rs
> 
> 
> Summary over all repositories:
>    8 files changed, 391 insertions(+), 29 deletions(-)
> 
> --
> Generated by murpp 0.12.1