Re: [PATCH proxmox-yew-widget-toolkit 2/5] widget: data table: only extend explicit select all to new rows

[Dominik Csapak <d.csapak@proxmox.com>]

even that i find too much.

A pattern I for example use often in UIs (even in our Extjs ones):

* filter by some pattern
* press 'select all' ( all visible are selected )
* unfilter
* select some others too

this would not work with this.

Maybe we need to have some different modes for select all?
* Automatic (status-quo, as default?)
* All (your patch)
* Visible (my use case from above)



On 10/28/26 4:15 PM, Nicolas Frey wrote:
> the "all" status was also set when every visible row happened to be
> selected, so clearing a filter after selecting all matching rows
> selected the whole table.
> 
> remember whether select all was explicitly requested via the header,
> and only then extend the selection on data changes.
> 
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   src/widget/data_table/data_table.rs | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/src/widget/data_table/data_table.rs b/src/widget/data_table/data_table.rs
> index e846522..90f37ea 100644
> --- a/src/widget/data_table/data_table.rs
> +++ b/src/widget/data_table/data_table.rs
> @@ -518,6 +518,8 @@ pub struct PwtDataTable<S: DataStore> {
>       cursor: Option<Cursor>,
>       last_select_position: Option<usize>,
>       selection_status: RowSelectionStatus,
> +    /// Whether all rows were explicitly selected, so that rows added later get selected too.
> +    select_all_requested: bool,
> 
>       _selection_observer: Option<SelectionObserver>,
> 
> @@ -770,9 +772,11 @@ impl<S: DataStore> PwtDataTable<S> {
>           }
>           selection.bulk_select(keys);
>           self.selection_status = RowSelectionStatus::All;
> +        self.select_all_requested = true;
>       }
> 
>       fn clear_selection(&mut self, props: &DataTable<S>) {
> +        self.select_all_requested = false;
>           if let Some(selection) = &props.selection {
>               selection.clear();
>           }
> @@ -1200,6 +1204,7 @@ impl<S: DataStore + 'static> Component for PwtDataTable<S> {
>               cursor: None,
>               last_select_position: None,
>               selection_status: RowSelectionStatus::Nothing,
> +            select_all_requested: false,
>               _selection_observer,
> 
>               active_column: 0,
> @@ -1245,6 +1250,9 @@ impl<S: DataStore + 'static> Component for PwtDataTable<S> {
>           match msg {
>               Msg::SelectionChange => {
>                   self.update_selection_status(props);
> +                if self.selection_status != RowSelectionStatus::All {
> +                    self.select_all_requested = false;
> +                }
>                   true
>               }
>               Msg::DataChange => {
> @@ -1259,7 +1267,10 @@ impl<S: DataStore + 'static> Component for PwtDataTable<S> {
>                   }
>                   self.update_scroll_info(props);
> 
> -                if self.selection_status == RowSelectionStatus::All {
> +                // only an explicit select all extends to new rows. deriving it from the selection
> +                // status would select every row once a filter is removed, if all rows that
> +                // matched the filter happened to be selected.
> +                if self.select_all_requested {
>                       self.select_all(props);
>                   } else {
>                       self.cleanup_selection(props);
> --
> 2.47.3