From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DA38D1FF09C for ; Mon, 02 Nov 2026 15:12:17 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9D41321425; Mon, 02 Nov 2026 15:12:17 +0100 (CET) Message-ID: Date: Mon, 2 Nov 2026 15:12:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component To: Nicolas Frey , yew-devel@lists.proxmox.com References: <20261028151517.518742-1-n.frey@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20261028151517.518742-1-n.frey@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793628733713 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.337 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: THJ4HPAZDLPMTNUI6EP3ESFAHHZF6K54 X-Message-ID-Hash: THJ4HPAZDLPMTNUI6EP3ESFAHHZF6K54 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the patches, i wrote some comments on the individual patches On 10/28/26 4:15 PM, Nicolas Frey wrote: > as it's already been used in internal GUI, put it into the yew > widget toolkit for potential future use in our products. > > first patch is something independent that I noticed while looking > through the data table code. the following two pathces fix existing issues > regarding multi select in a datatable, namely to do with how selection > behaves in combination with filtering. > > this multi-select implementation addresses the issue the doc comment > for the Combobox mentions, by listing the selected values in a comma > separated list and breaking at the form input's width. > > proxmox-yew-widget-toolkit: > > Nicolas Frey (5): > widget: data table: simplify lookup of keys near the cursor > widget: data table: only extend explicit select all to new rows > widget: grid picker: keep selected records hidden by the filter > widget: form: implement multi select field > widget: form: combobox: update doc to point to `MultiSelect` > > src/state/data_store.rs | 3 + > src/state/store.rs | 4 + > src/state/tree_store/mod.rs | 4 + > src/widget/data_table/data_table.rs | 89 +++++--- > src/widget/form/combobox.rs | 5 +- > src/widget/form/mod.rs | 5 + > src/widget/form/multi_select.rs | 308 ++++++++++++++++++++++++++++ > src/widget/grid_picker.rs | 2 + > 8 files changed, 391 insertions(+), 29 deletions(-) > create mode 100644 src/widget/form/multi_select.rs > > > Summary over all repositories: > 8 files changed, 391 insertions(+), 29 deletions(-) > > -- > Generated by murpp 0.12.1